From ec34253535b5dbd686c17ab7109f01afb5ccd27b Mon Sep 17 00:00:00 2001 From: Rainer Gerhards Date: Fri, 29 Jun 2018 12:43:27 +0200 Subject: [PATCH] more explicit error msg with message modification mod on queue Message modification modules do not work if used with a non-direct queue. We now make this more explicit in the config parsing error message. closes https://github.com/rsyslog/rsyslog/issues/1323 --- action.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/action.c b/action.c index 4fc4e8739..e69eedd46 100644 --- a/action.c +++ b/action.c @@ -575,7 +575,9 @@ actionConstructFinalize(action_t *__restrict__ const pThis, struct nvlst *lst) if(pThis->bUsesMsgPassingMode && pThis->pQueue->qType != QUEUETYPE_DIRECT) { parser_warnmsg("module %s with message passing mode uses " "non-direct queue. This most probably leads to undesired " - "results", (char*)modGetName(pThis->pMod)); + "results. For message modificaton modules (mm*), this means " + "that they will have no effect - " + "see https://www.rsyslog.com/mm-no-queue/", (char*)modGetName(pThis->pMod)); } /* and now reset the queue params (see comment in its function header!) */ @@ -2055,8 +2057,6 @@ addAction(action_t **ppAction, modInfo_t *pMod, void *pModData, CHKiRet(actionConstructFinalize(pAction, lst)); - /* TODO: if we exit here, we have a (quite acceptable...) memory leak */ - *ppAction = pAction; /* finally store the action pointer */ finalize_it: