Rainer Gerhards ed91aebc42 devtools: fold local review experiment into planner
Why:
The old AI local-review workflow was experimental, duplicated newer
validation guidance, and still carried stale review behavior on main.

Impact:
Local validation keeps useful checks in the maintained planner and
removes the obsolete experiment while retaining shared prompt assets.

Before/After:
Before, local review policy lived partly in an unused AI script and a
deleted workflow entry point. After, the planner and skills own the
reusable checks and prompt guidance.

Technical Overview:
Remove ai/local-review-workflow.sh and .agent/workflows/audit.md.
Teach devtools/local-validation-plan.sh to derive its default base from
RSYSLOG_LOCAL_VALIDATION_BASE, rsyslog.localValidationBase, or the
worktree HEAD reflog baseline.
Use the same base for local Cubic review so committed branch changes are
reviewed against the worktree creation point.
Add advisory raw allocation and test antipattern scans, and run fast mock
distcheck for distribution-risk test/build changes.
Fold the old audit prompt guidance into the local container testing skill
as late manual prompt audits without launching another AI CLI.
Document ai/ as the central shared prompt-asset library and remove stale
references to deleted workflow paths.

With the help of AI-Agents: OpenAI Codex
2026-06-02 10:15:24 +02:00
..

AI Prompt Assets for rsyslog

This directory contains maintained prompt assets that agents may read during rsyslog development, review, documentation, and support workflows.

Purpose

The ai directory keeps reusable AI-facing context outside the rsyslog core. These files are not executable validation scripts and should not launch local AI tooling by themselves. Active agents read the relevant prompt text and apply it to the current diff or task.

Current Assets

  • rsyslog_memory_auditor/: memory ownership, cleanup, leak, and NULL-check review prompts for C changes.
  • rsyslog_bug_finder/: resource, concurrency, lock-order, and lifecycle review prompt.
  • rsyslog_commit_assistant/: commit message guidance.
  • rsyslog_doc_assistant/ and rsyslog_code_doc_builder/: documentation prompt assets.
  • rsyslog_issue_assistant/ and support_gpt/: issue and support prompt assets.

Workflow

Prompt-based audits are intentionally manual from repository tooling. See .agent/skills/rsyslog_local_container_testing/SKILL.md for when agents should apply these prompts as late validation passes.