rsyslog/rsyslog
1
0
Fork 0
mirror of https://github.com/rsyslog/rsyslog.git synced 2026-06-20 00:32:56 +02:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #5768 from rsyslog/codex/fix-bug-in-issue-#382

Browse Source 
Document MsgSetRawMsg side effects
This commit is contained in:
Rainer Gerhards 2025-07-12 12:54:27 +02:00 committed by GitHub
commit 138540d3e1
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 9 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
runtime/msg.c
View File

@ -2967,7 +2967,9 @@ MsgTruncateToMaxSize(smsg_t *const pThis)
/* set raw message in message object. Size of message is provided. /* set raw message in message object. Size of message is provided.
* The function makes sure that the stored rawmsg is properly * The function makes sure that the stored rawmsg is properly
* terminated by '\0'. * terminated by '\0'. When a message is replaced, we try to keep
* the existing MSG offset valid so that modules modifying only the
* raw text do not need to recompute it.
* rgerhards, 2009-06-16 * rgerhards, 2009-06-16
*/ */
void ATTR_NONNULL() void ATTR_NONNULL()
@ -2991,7 +2993,12 @@ MsgSetRawMsg(smsg_t *const pThis, const char*const pszRawMsg, const size_t lenMs
memcpy(pThis->pszRawMsg, pszRawMsg, pThis->iLenRawMsg); memcpy(pThis->pszRawMsg, pszRawMsg, pThis->iLenRawMsg);
pThis->pszRawMsg[pThis->iLenRawMsg] = '\0'; /* this also works with truncation! */ pThis->pszRawMsg[pThis->iLenRawMsg] = '\0'; /* this also works with truncation! */
/* correct other information */ /*
* Update cached MSG length. When offMSG already points into the
* message (e.g. after initial parsing) adjusting iLenMSG avoids the
* need for a costly re-parse in modules like mmexternal which may
* replace the raw message text.
*/
if(pThis->iLenRawMsg > pThis->offMSG) if(pThis->iLenRawMsg > pThis->offMSG)
pThis->iLenMSG += deltaSize; pThis->iLenMSG += deltaSize;
else else