rsyslog/rsyslog
1
0
Fork 0
mirror of https://github.com/rsyslog/rsyslog.git synced 2025-12-17 21:00:42 +01:00
Code Issues Packages Projects Releases Wiki Activity

"fix" Coverity scan CID 185431

Browse Source
This commit is contained in:
Rainer Gerhards 2017-12-10 15:07:11 +01:00
parent 96b08ec1b0
commit 444c30ff05
1 changed files with 18 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

19
tools/omdiscard.c
View File

@ -116,7 +116,24 @@ CODE_STD_STRING_REQUESTparseSelectorAct(0)
} else {
iRet = RS_RET_CONFLINE_UNPROCESSED;
}
CODE_STD_FINALIZERparseSelectorAct
/* we do not use the macro
* CODE_STD_FINALIZERparseSelectorAct
* here as this causes a Coverity ID "false positive" (CID 185431).
* We don't see an issue with using the copy&pasted code as it is unlikly
* to change for this (outdated) module.
*/
finalize_it: ATTR_UNUSED; /* semi-colon needed according to gcc doc! */
if(iRet == RS_RET_OK || iRet == RS_RET_OK_WARN || iRet == RS_RET_SUSPENDED) {
*ppModData = pData;
*pp = p;
} else {
/* cleanup, we failed */
if(*ppOMSR != NULL) {
OMSRdestruct(*ppOMSR);
*ppOMSR = NULL;
}
}
/* END modified macro text */
ENDparseSelectorAct