rsyslog/rsyslog
1
0
Fork 0
mirror of https://github.com/rsyslog/rsyslog.git synced 2025-12-13 07:10:42 +01:00
Code Issues Packages Projects Releases Wiki Activity

CI: suppress TSAN exception for known-good case

Browse Source 
We do not use a mutex an epd, but we do always access it in
pure sequence. Adding a mutex just to cover this "cosmetic"
would result in uncesseary performance penalty.
This commit is contained in:
Rainer Gerhards 2022-07-05 12:10:38 +02:00
parent d27e6a9c19
commit 6ef5e826d7
No known key found for this signature in database
GPG Key ID: 0CB6B2A8BE80B499
2 changed files with 17 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
plugins/imptcp/imptcp.c
View File

@ -397,18 +397,28 @@ static rsRetVal resetConfigVariables(uchar __attribute__((unused)) *pp, void __a
static rsRetVal addLstn(ptcpsrv_t *pSrv, int sock, int isIPv6); static rsRetVal addLstn(ptcpsrv_t *pSrv, int sock, int isIPv6);
/* function to suppress TSAN known-good case
* We do not use a mutex an epd, but we do always access it in
* pure sequence. Adding a mutex just to cover this "cosmetic"
* would result in uncesseary performance penalty.
*/
static void ATTR_NONNULL()
imptcp_destruct_epd(ptcpsess_t *const pSess) {
free(pSess->epd);
pSess->epd = NULL;
}
/* some simple constructors/destructors */ /* some simple constructors/destructors */
static void static void ATTR_NONNULL()
destructSess(ptcpsess_t *pSess) destructSess(ptcpsess_t *const pSess)
{ {
imptcp_destruct_epd(pSess);
free(pSess->pMsg_save); free(pSess->pMsg_save);
free(pSess->pMsg); free(pSess->pMsg);
free(pSess->epd);
prop.Destruct(&pSess->peerName); prop.Destruct(&pSess->peerName);
prop.Destruct(&pSess->peerIP); prop.Destruct(&pSess->peerIP);
/* TODO: make these inits compile-time switch depending: */ /* TODO: make these inits compile-time switch depending: */
pSess->pMsg = NULL; pSess->pMsg = NULL;
pSess->epd = NULL;
free(pSess); free(pSess);
} }

3
tests/tsan-rt.supp
View File

@ -1,3 +1,6 @@
# supressions for LLVM TSAN
# doc: https://github.com/google/sanitizers/wiki/ThreadSanitizerSuppressions
race:^imptcp_destruct_epd$
race:doLogMsg race:doLogMsg
race:setlocale race:setlocale
race:doSIGTTIN race:doSIGTTIN