rsyslog/rsyslog
1
0
Fork 0
mirror of https://github.com/rsyslog/rsyslog.git synced 2025-12-20 09:40:42 +01:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #2061 from rgerhards/cid-185363

Browse Source 
"fix" Coverity false positive CID 185363
This commit is contained in:
Rainer Gerhards 2017-11-20 11:44:24 +01:00 committed by GitHub
commit 8f73070f18
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 8 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
plugins/mmexternal/mmexternal.c
View File

@ -2,7 +2,7 @@
* This core plugin is an interface module to message modification
* modules written in languages other than C.
*
* Copyright 2014-2016 by Rainer Gerhards
* Copyright 2014-2017 by Rainer Gerhards
*
* This file is part of rsyslog.
*
@ -268,6 +268,10 @@ processProgramReply(wrkrInstanceData_t *__restrict__ const pWrkrData, smsg_t *co
/* execute the child process (must be called in child context
* after fork).
*/
/* dummy vars to store "dup()" results - keeps Coverity happy */
static int dummy_stdin;
static int dummy_stdout;
static int dummy_stderr;
static void __attribute__((noreturn))
execBinary(wrkrInstanceData_t *pWrkrData, int fdStdin, int fdStdOutErr)
{
@ -278,16 +282,16 @@ execBinary(wrkrInstanceData_t *pWrkrData, int fdStdin, int fdStdOutErr)
char *newenviron[] = { NULL };
fclose(stdin);
if(dup(fdStdin) == -1) {
if((dummy_stdin = dup(fdStdin)) == -1) {
DBGPRINTF("mmexternal: dup() stdin failed\n");
}
close(1);
if(dup(fdStdOutErr) == -1) {
if((dummy_stdout = dup(fdStdOutErr)) == -1) {
DBGPRINTF("mmexternal: dup() stdout failed\n");
}
/* todo: different pipe for stderr? */
close(2);
if(dup(fdStdOutErr) == -1) {
if((dummy_stderr = dup(fdStdOutErr)) == -1) {
DBGPRINTF("mmexternal: dup() stderr failed\n");
}