rsyslog/rsyslog
1
0
Fork 0
mirror of https://github.com/rsyslog/rsyslog.git synced 2025-12-19 19:40:41 +01:00
Code Issues Packages Projects Releases Wiki Activity

ommysql: do not duplicate entries on failed transaction

Browse Source 
If a multi-message batch contains data errors, messages may be
duplicated as connection close is implicit commit (not rollback).
This patch introduces a specific rollback request in those cases.

closes https://github.com/rsyslog/rsyslog/issues/1829
This commit is contained in:
Rainer Gerhards 2017-10-10 14:28:44 +02:00
parent e9a27a0c53
commit cdd7b62c60
1 changed files with 4 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
plugins/ommysql/ommysql.c
View File

@ -309,6 +309,10 @@ CODESTARTcommitTransaction
if(iRet != RS_RET_OK if(iRet != RS_RET_OK
&& iRet != RS_RET_DEFER_COMMIT && iRet != RS_RET_DEFER_COMMIT
&& iRet != RS_RET_PREVIOUS_COMMITTED) { && iRet != RS_RET_PREVIOUS_COMMITTED) {
if(mysql_rollback(pWrkrData->hmysql) != 0) {
DBGPRINTF("ommysql: server error: transaction could not be rolled back\n");
}
closeMySQL(pWrkrData);
FINALIZE; FINALIZE;
} }
} }