12419 Commits

Author SHA1 Message Date
Rainer Gerhards
dfdc2f0445 testbench: disable imjournal tests temporarily due to issues
So we permit CI to work well while we work on solving the issue.

see: https://github.com/rsyslog/rsyslog/issues/2564
2018-03-19 19:06:24 +01:00
Rainer Gerhards
a4d078a784 maintain ChangeLog 2018-03-19 18:51:55 +01:00
Rainer Gerhards
329314709a
Merge pull request #2519 from richm/omelasticsearch-tls
omelasticsearch - add support for CA cert, client cert auth
2018-03-19 17:43:25 +01:00
Rainer Gerhards
47c7d9173a
Merge pull request #2554 from rgerhards/solaris-gcc
fix build issues on Solaris with gcc
2018-03-19 17:39:16 +01:00
Rainer Gerhards
a910ac65bd
Merge pull request #2559 from rgerhards/disable-omprog-tests
testbench: disable some racy omprog tests
2018-03-19 17:36:20 +01:00
Rainer Gerhards
87020b2f45
Merge pull request #2563 from rgerhards/fix-sendrcv_relp
nitfix: test included invalid parameter
2018-03-19 14:32:48 +01:00
Jan Gerhards
22fc00e897 rscript: make function modules loadable
function modules add functions to rainerscript dynamically,
change http_request into such a module (enabled by default).
This module can be used as a sample for future function modules.
2018-03-19 11:49:36 +01:00
Rainer Gerhards
5b7adcb232 nitfix: test included invalid parameter
now also given action a name for easier debug log check
2018-03-19 11:29:34 +01:00
Maxime Graff
f3106c538f Increase UNIX socket backlog for performance under heavy load 2018-03-19 10:14:59 +01:00
Rainer Gerhards
f192ccc957 testbench: disable some racy omprog tests
these test are still instable and some concerns about their
validity at all have been raised. We now disable them to make
the testbench more reliable. Root cause needs to be investigated
and tests finally fixed or removed.

see also https://github.com/rsyslog/rsyslog/issues/2403
2018-03-19 08:37:21 +01:00
Rainer Gerhards
9c7d44e95c maintain ChangeLog 2018-03-19 08:34:56 +01:00
Rainer Gerhards
db5541a8db
Merge pull request #1992 from jsiwrk/feature/omprog_feedback_tests
omprog: added tests for transactions with feedback
2018-03-19 08:29:08 +01:00
Rainer Gerhards
ac9d77bae9 maintain ChangeLog 2018-03-18 13:10:45 +01:00
Rainer Gerhards
937abdd107
Merge pull request #2527 from hanazuki/improve-tests-glbl-umask
tests/glbl-umask.sh: Improve test stability
2018-03-18 13:09:11 +01:00
Rainer Gerhards
3c32c844b6 testbench: improve cleanup
some tests use rsyslog.out.* file names, which were so far not cleaned up.
This can lead to all sorts of problems, including failure of
"make distcheck" due to leftover files. We now delete all of these files
on cleanup. This should not have any undesired side-effects.

Thanks to Kasumi Hanazuki for spotting this problem.

see also https://github.com/rsyslog/rsyslog/pull/2527
2018-03-18 13:05:24 +01:00
Rainer Gerhards
193631eac7 stream/bugfix: memory leak on stream open if filename as already generated
this can happen if imfile reads a state file. On each open, memory for the
file name can be lost.

We detected this while working on imfile refactoring, there is no related
bug report. No specific test has been crafted, as the refactored imfile
tests catch it (as soon as they are merged).
2018-03-18 12:10:36 +01:00
Rainer Gerhards
1ea4bb2c42 fix build issues on Solaris with gcc 2018-03-18 11:07:16 +01:00
Rainer Gerhards
e2e4e18bd9
Merge pull request #2553 from rgerhards/lgtm-more-modules2
QA: enable even more modules in lgtm.com static analyzer
2018-03-18 10:18:37 +01:00
Rainer Gerhards
641912e9d3 tools/logctl: replace unsafe function
detected by lgtm static analyzer
2018-03-17 17:56:14 +01:00
Rainer Gerhards
4b00d2e4ed action.c: do not expose module-private static variable
detected by lgtm static analyzer
2018-03-17 17:20:09 +01:00
Rainer Gerhards
3b87d228d9 mmaudit: remove unused code
detected by lgtm static analyzer
2018-03-17 17:17:26 +01:00
Rainer Gerhards
015821d82c QA: add more modules to lgtm analyzer coverage 2018-03-17 16:48:20 +01:00
Joan Sala
2336e5ad65 omprog: added tests for transactions with feedback 2018-03-17 15:41:25 +01:00
Rainer Gerhards
77b7aec1c2 ompgsql: remove dead code
detected by lgtm static analyzer
2018-03-17 14:41:19 +01:00
Rainer Gerhards
7a170d86ea QA: enable even more modules in lgtm.com static analyzer 2018-03-17 14:22:41 +01:00
Rainer Gerhards
8070d9841d maintain ChangeLog 2018-03-17 12:52:59 +01:00
Rainer Gerhards
c0fc86d43e
Merge pull request #2551 from rgerhards/lgtm-more-modules
QA: make lgtm.com analyze more modules
2018-03-17 12:52:02 +01:00
Rainer Gerhards
e69bfa0650 maintain ChangeLog 2018-03-17 12:40:36 +01:00
Rainer Gerhards
80f2d145f5
Merge pull request #2526 from hanazuki/tests-missing-slash
tests/Makefile: Fix broken TESTS
2018-03-17 12:39:10 +01:00
Rainer Gerhards
ed1813dcb6
Merge pull request #2545 from hrak/master
omfile: Fix wrong order of arguments for errmsg
2018-03-17 12:37:21 +01:00
Rainer Gerhards
1fe2b08b89
Merge pull request #2546 from rgerhards/i2421
fix memory leak in imfile readmode 0
2018-03-17 12:36:05 +01:00
Rainer Gerhards
948f499456
Merge pull request #2550 from rgerhards/lgtm-1
fixing issues found by lgtm.com static analyzer
2018-03-17 12:34:30 +01:00
Rainer Gerhards
e64008b9c4 QA: make lgtm.com analyze more modules 2018-03-17 12:33:37 +01:00
Rainer Gerhards
a21e87f5ba fix invalidly-placed header guard
detected by lgtm static analyzer
2018-03-17 10:29:19 +01:00
Rainer Gerhards
6d850a1aa9 fix behaviour not totally defined by C standard
see also: https://stackoverflow.com/questions/32916575/how-to-use-zd-specifier-with-printf

detected by lgtm static analyzer
2018-03-17 10:26:27 +01:00
Rainer Gerhards
31219c6a6d fix missing header guard
detected by lgtm.com static analyzer
2018-03-16 19:06:43 +01:00
Rainer Gerhards
4cba3c8b20 fix invalid HTML header in JavaScript
detected by lgtm.com static analyzer
2018-03-16 19:03:03 +01:00
Rainer Gerhards
db7b8f07c1 remove dead code
Expression is actually constant under given code. To be on the safe
side for future code changes, I put in a guard assert().

detected by lgtm.com static analyzer
2018-03-16 18:58:11 +01:00
Rainer Gerhards
edf7c7145b
Merge pull request #2548 from sjvs/add-lgtm.yml-for-lgtm.com
Add lgtm.yml configuration for analysis on lgtm.com
2018-03-16 17:23:17 +01:00
Bas van Schaik
dabb7b7231 Add lgtm.yml configuration for analysis on lgtm.com 2018-03-16 16:06:51 +00:00
Rainer Gerhards
a56ba762eb
Merge pull request #2522 from deoren/changelog-param-fix
Changelog: Fix config.enabled parameter name
2018-03-15 14:18:13 +01:00
Rainer Gerhards
b2067393d6
Merge pull request #2539 from jgerhards/rscript-Ptr
rscript: refactor to use function pointers for script functions
2018-03-15 14:17:46 +01:00
Rainer Gerhards
ce88147209 testbench: activate new test now that fix is present 2018-03-15 13:25:17 +01:00
Rainer Gerhards
c55f37ef71 bugfix/imfile: memory leak in readMode 0
Bug is actually in stream object, but currently exposed only via imfile.
Happens when in readMode 0 a partial line is read and no more data is
present in the file during that iteration. One partial message is lost
in this case.

closes https://github.com/rsyslog/rsyslog/issues/2421
2018-03-15 13:23:26 +01:00
Rainer Gerhards
fba936b0b1 testbench: add testcase for memory leak in stream class
Bug is currently exposed only via imfile. Happens when in readMode 0 a
partial line is read and no more data is present in the file during
that iteration. One partial message is lost in this case.

Note: this just adds the test, but does not activate it. Activation
shall happen after fix is crafted.

see also https://github.com/rsyslog/rsyslog/issues/2421
2018-03-15 13:22:31 +01:00
Hans Rakers
b617456a48 Fix wrong order of arguments for errmsg 2018-03-15 10:49:56 +01:00
Jan Gerhards
89e16c53dc rscript: refactor to use function pointers for script functions
calling and identifying a script function now works via
a function pointer. Going forward, this will be used when
making loadable functions in rainerscript.
2018-03-14 09:33:13 +01:00
Kasumi Hanazuki
2ea7d7eef1 tests/glbl-umask.sh: Improve test stability
This patch improves the stability of tests/glbl-umask.sh, which now fails
when running after tests/rawmsg-after-pri.sh, since the glob pattern rsyslog.o*
matches rsyslog.out.compare, created by rawmsg-after-pri.sh.
2018-03-09 14:12:59 +09:00
Kasumi Hanazuki
907882a241 tests/Makefile: Fix broken TESTS
This patch fixes the list of TESTS, broken by a line without the backslash
introduced in Commit 87f296fd2e667e95f38991a8a7caf84c3458e7c9.
2018-03-09 13:23:32 +09:00
Rainer Gerhards
07d649d765
Merge pull request #2515 from jgerhards/script-refactor
rscript: refactor all functions
2018-03-08 09:24:53 +01:00