testbench: cleanup, including fix of false positives
some environments have faulty components; also some tests failed simply because
their runtime *is* far longer than supported by default. Also re-instantiated
some "lost" tests and done some general cleanup.
They now wait for the output file to have the execpected number of lines
before rsyslog is shutdown. From past experience we know that the
shutdown "queue empty detection" is not 100% reliable on very slow
machines/environments.
Also now permit interactivly running tests without explicitly setting
$srcdir. This now works if we are inside ./tests and fails, as before,
when we are in a different directory.
Detected by shellcheck via CodeFactor.io
Support tools (like tcpflood) are also upgraded to support the
necessary dynamic port.s
This is part of the effort to make parallel testing possible.
We move parts of the cleanup to the buildbot cleanup, as we cannot
clean out instances on each test when we run parallel tests.
changes some of the test commands to use bash functions
includes some small bug fixes to tests where bugs were
previously not seen due to different plumbing.
