Allan Park
a8a754ee40
Add possibility to use the asyncronous mode of the libksi (>=3.16) (Issue 2090)
2017-11-23 13:11:41 +02:00
Hugo SOSZYNSKI
1d55cad041
Made the funtions static hopping to correct the "no previous prototype" problème and suppresion of trailing spaces
2017-11-23 11:38:10 +01:00
Rainer Gerhards
a82bb9cb2d
"fix" Coverity scan false positives
2017-11-23 09:15:56 +01:00
Rainer Gerhards
e94c8413ed
omkafka: trying to "fix" Coverity scan false positive
2017-11-22 18:39:25 +01:00
Rainer Gerhards
34fb903251
omkafka: fix coding style (no functional changes)
2017-11-22 18:36:18 +01:00
Rainer Gerhards
fe9b00c5b0
omkafka: add warning message if default broker is used
...
this happens if the "brokers" paraemter is not given. Previously,
this was done silently, now the user knows.
2017-11-22 18:14:25 +01:00
Rainer Gerhards
0689ce6128
imkafka bugfix: segfault if "broker" parameter is not specified
...
Now emits warning message instead and uses hardcoded default
(which usually matches where the kafka broker can be found).
fixes https://github.com/rsyslog/rsyslog/issues/2085
2017-11-22 18:12:45 +01:00
Rainer Gerhards
c29ec7f52c
Merge pull request #2080 from rgerhards/i-2040bis
...
udp socket creation: make IPFREEBIND work
2017-11-22 17:36:41 +01:00
Rainer Gerhards
e88605f76d
Merge pull request #2083 from jgerhards/errmsg-imczmq
...
imczmq: use new errmsg interface
2017-11-22 17:36:24 +01:00
Rainer Gerhards
719dcd0ff0
Merge pull request #2081 from jgerhards/errmsg-imzmq3c
...
imzmq3: use new errmsg interface
2017-11-22 16:16:55 +01:00
Rainer Gerhards
43ec4853c8
Merge pull request #2082 from jgerhards/errmsg-omtclc
...
omtcl: use new errmsg interface
2017-11-22 16:15:43 +01:00
Jan Gerhards
f2cc076e5b
imczmq: use new errmsg interface
2017-11-22 14:39:28 +01:00
Jan Gerhards
d546fb4779
omtcl: use new errmsg interface
2017-11-22 14:35:36 +01:00
Jan Gerhards
8bc6628f2c
imzmq3: use new errmsg interface
2017-11-22 14:26:13 +01:00
Rainer Gerhards
464a6295ba
udp socket creation: make IPFREEBIND work
...
... and also solve a socket leak that pre-8.31 occurred when the option
was enabled.
Special thanks to github user amg1127 who analysed the situation and
actually provided the original patch for the issue. Unfortunately, the
existing code base was really bad, and so I needed to do some refactoring
first. My patch here is modelled exactly after amg1127's patch, but
bases on the refactoring.
Full credits for the patch belong to amg1127.
see also https://github.com/rsyslog/rsyslog/pull/2049
closes https://github.com/rsyslog/rsyslog/issues/2040
2017-11-22 13:58:06 +01:00
Rainer Gerhards
eb537ec6ba
Merge pull request #2079 from rgerhards/lookup-cosmetic
...
some primarily cosmetic changes
2017-11-22 13:51:43 +01:00
Rainer Gerhards
85a6e6f161
maintain ChangeLog
2017-11-22 12:36:49 +01:00
Rainer Gerhards
be61fc6b0d
Merge pull request #2068 from rgerhards/i-1885bis
...
mmdblookup: guard against potential libmaxminddb thread unsafeness
2017-11-22 12:34:43 +01:00
Rainer Gerhards
047624147c
some primarily cosmetic changes
2017-11-22 12:33:03 +01:00
Rainer Gerhards
bb0d3e0546
Merge pull request #2078 from rgerhards/nitfix
...
some minor fixes, remove Coverity Scan "false positives"
2017-11-22 12:30:35 +01:00
Rainer Gerhards
b43a226bb5
maintain ChangeLog
2017-11-22 11:26:25 +01:00
Rainer Gerhards
0aeeb4702d
Merge pull request #2077 from rgerhards/imkafka
...
imkafka: better error reporting and code cleanup
2017-11-22 11:25:22 +01:00
Rainer Gerhards
9aa41d515a
"fix" Coverity scan false positives
...
plus some mild refactoring while we are at it
2017-11-22 11:16:17 +01:00
Rainer Gerhards
a4c7f2ac81
module-template framework: avoid compiler warning in some legal cases
...
the finalize_it: label is required, but not always used, which each
time results in a compiler warning that needs to be worked around.
Now this is fixed once and for all for gcc and clang - the others
will probably not complain in any case. Great solution until something
comes up that makes us need a revision.
2017-11-22 11:08:34 +01:00
Rainer Gerhards
017a06e433
Merge pull request #2076 from rgerhards/coverity
...
"fix" Coverity false positives
2017-11-22 10:42:59 +01:00
Rainer Gerhards
1cba0458f6
imkafka: better error reporting and code cleanup
...
Getting the code more into rsyslog style, fixing up TODOs,
improving error reporting
2017-11-22 09:31:55 +01:00
Rainer Gerhards
b85164b503
Merge pull request #2075 from rgerhards/imkafka-errmsg
...
nitfixes
2017-11-22 09:19:10 +01:00
Rainer Gerhards
338e09cd09
"fix" Coverity scan false positive CID 185398
2017-11-22 08:38:58 +01:00
Rainer Gerhards
6e473f3ba0
"fix" Coverity valse positive, CID 185368
2017-11-22 08:34:15 +01:00
Rainer Gerhards
cc08c4a724
prevent close(-1) call - regression from yesterday's refactoring
...
Detected by Coverity scan, CID 185833
2017-11-22 08:23:04 +01:00
Rainer Gerhards
2b494caff1
imkafka bugfix: error message was invalidly reported
...
...even when all worked well.
2017-11-22 08:18:13 +01:00
Rainer Gerhards
ad20665082
Merge branch 'master' of https://github.com/rsyslog/rsyslog
2017-11-21 16:51:28 +01:00
Rainer Gerhards
f3a19079f8
maintain ChangeLog
2017-11-21 16:51:11 +01:00
Rainer Gerhards
154bb99d03
Merge pull request #2069 from rgerhards/i-2040
...
refactor create_udp_socket
2017-11-21 16:49:40 +01:00
Rainer Gerhards
82cefb5192
maintain ChangeLog
2017-11-21 15:35:35 +01:00
Rainer Gerhards
bfcba79223
Merge pull request #2066 from rgerhards/kafka-termination-problem
...
testbench: add kafka valgrind tests
2017-11-21 15:33:26 +01:00
Rainer Gerhards
a811fb8fb7
testbench: add basic test for omelasticsearch with ES 6.0
2017-11-21 15:29:48 +01:00
Rainer Gerhards
61ccf4a159
testbench: improve elasticsearch test harness
...
see also https://github.com/rsyslog/rsyslog/issues/1989
2017-11-21 15:29:48 +01:00
8d1ffbf3c3
testsuite: Added es-basic-abort test to simulate elasticsearch shutdown/restart
...
Also changed start/stop method in diag.sh for elasticsearch
2017-11-21 15:28:15 +01:00
013c7304e9
testsuite: Added support to download, setup and start Elasticsearch from source
...
Works equal like for kafka and zookeeper. Elasticsearch is downloaded, configured and
started/stopped by the diag.sh script. Normal user access is sufficient.
Only es-basic.sh test has been adjusted with the new
method. Elasticsearch instance is limited to 128MB memory, should be sufficient for
the testbench.
2017-11-21 15:28:15 +01:00
Rainer Gerhards
ee1499f462
refactor create_udp_socket
...
Function used very old style and was hard to read. Now also supports
strucutred handling of exceptions.
see also https://github.com/rsyslog/rsyslog/pull/2049
see also https://github.com/rsyslog/rsyslog/issues/2040
2017-11-21 14:13:03 +01:00
Rainer Gerhards
603c30568b
Merge pull request #2065 from rgerhards/cid-185500
...
imjournal: refactor journal state file load
2017-11-21 13:15:16 +01:00
Rainer Gerhards
1f859e7ad6
testbench/kafka: add valgrind test for kafka
...
Note: we need to add a supression file for a memory leak that looks
like it is caused by librdkafka.
See https://github.com/edenhill/librdkafka/issues/1536
for more details.
Once this issue is finally resolved, we should revisit the approach taken.
closes https://github.com/rsyslog/rsyslog/issues/2050
2017-11-21 13:12:29 +01:00
Rainer Gerhards
cf22e85c59
Merge pull request #2064 from rgerhards/coverity-false-positives
...
"fix" Coverity false positives
2017-11-21 13:10:42 +01:00
Rainer Gerhards
5e21f4e829
mmdblookup: guard against potential libmaxminddb thread unsafeness
...
see also https://github.com/rsyslog/rsyslog/issues/1885#issuecomment-344882616
2017-11-21 11:38:12 +01:00
Rainer Gerhards
08f2d10caa
maintain ChangeLog
2017-11-21 11:28:51 +01:00
Rainer Gerhards
a498d62dfd
Merge pull request #2063 from rgerhards/i-1933
...
remove systemd embedded code, use library instead
2017-11-21 11:21:40 +01:00
29fc98d30d
imkafka: Added support to output kafka debug messages into rsyslog log.
...
Only enabled if rsyslog is compiled in debug mode.
Also added rd_kafka_consumer_close before rd_kafka_destroy.
2017-11-21 09:23:55 +01:00
Rainer Gerhards
dc2e06d6b8
"fix" Coverity scan cosmetic issues
...
Let us get rid of some dismissed CID entries...
2017-11-21 09:15:31 +01:00
Rainer Gerhards
acb62dfdab
remove systemd embedded code, use library instead
...
Since the early days rsyslog uses the orginal systemd embedded
interface code. This commit changes it to libsystemd where available.
If we do not find libsystemd, we assume the system does not use
systemd, which is a safe assumption nowadays. This ensures we use the
fresh interface code and also removes bloat from our project.
closes https://github.com/rsyslog/rsyslog/issues/1933
2017-11-21 09:12:39 +01:00
