Why: the first deterministic policy workflow covers the most obvious
repo rules, but it still leaves new-module build wiring and parameter
doc coverage to human review.
Impact: the focused review now also checks top-level build wiring for
new modules and warns when new module parameters lack reference docs.
Before/After: before the workflow only checked tests, doc distribution,
and basic module onboarding; after it also covers module build manifests
and parameter reference doc sync.
Technical Overview:
Extend the review package builder with deterministic facts for new
module build wiring against the top-level Makefile.am and configure.ac.
Add a parameter-doc-sync rule that compares newly introduced
cnfparamdescr names against the expected files under
`doc/source/reference/parameters/`.
Teach the deterministic evaluator about the two new checks and update
the workflow trigger/doc text to match the expanded rule set.
With the help of AI-Agents: Codex
Why: rsyslog CI already covers generic quality well, but it lacked
repository-specific policy checks in a few recurring areas.
Impact: pull requests now get a focused deterministic policy check
for test registration, doc distribution sync, and new-module
onboarding.
Before/After: before these repository rules depended on reviewer
memory; after CI checks them directly and reports all findings in one
run.
Technical Overview:
Add a dedicated workflow that only triggers for policy-relevant
changes and builds a focused review package from the pull-request
diff.
Evaluate the focused checks deterministically for tests, docs, and
new modules, then normalize the results into a workflow summary.
Fail the workflow only for deterministic policy violations, while
still printing advisory warnings so contributors can address all
follow-up in one iteration.
With the help of AI-Agents: Codex
