rsyslog/rsyslog
1
0
Fork 0
mirror of https://github.com/rsyslog/rsyslog.git synced 2025-12-20 09:40:42 +01:00
Code Issues Packages Projects Releases Wiki Activity
11,361 Commits 67 Branches 505 Tags
Commit Graph

11361 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Rainer Gerhards
2b169c2c20 imkafka: remove unnecessary check 
checked invariant as if it could be different. This is not the case.
As a safety precaution, put an assert() into the code.

Detected by Coverity Scan, CID 185725
 2017-11-07 17:11:26 +01:00
Rainer Gerhards
5116ea13ee
Merge pull request #1980 from rgerhards/cid-185357 
improve error messages in case of failing to obtain group info
 2017-11-07 16:06:18 +01:00
Rainer Gerhards
e757c329a4
Merge pull request #1981 from alorbach/kafka-coverity-fixes 
kafka: fixed multiple coverity scan issues
 2017-11-07 16:05:06 +01:00
Jiri Vymazal
c091ac8164 remove incorrect action option from testsuite conf 2017-11-07 14:28:03 +01:00
Stephen Workman
2c2679ff12 Add comments for clarity. 2017-11-07 08:24:56 -05:00
Andre Lorbach
37636969aa kafka: fixed multiple coverity scan issues 
CID 185720, 185719 fixed by correcting expression check for MsgFile handle.
CID 185723 fixed by removing CHKiRET
CID 185722 added additional check (stat) for MsgFile before unlink

Fixed 2 clang issues in imkafka as well
 2017-11-07 13:24:23 +01:00
Rainer Gerhards
6762c9907d CI: add ability to activate extra modules for static analysis 2017-11-07 13:22:02 +01:00
Rainer Gerhards
38084023cc improve error messages in case of failing to obtain group info 
Also fixes Coverity Scan CID 185357.
 2017-11-07 13:21:09 +01:00
Rainer Gerhards
43a5e2e96f
Merge pull request #1973 from rgerhards/less-pragmas-grammar 
remove the number of warning-avoidance pragmas
 2017-11-07 13:20:41 +01:00
Rainer Gerhards
ff4a98506b
Merge pull request #1982 from rgerhards/travis-fix-llvm-repo 
travis: fix invalid LLVM repository source
 2017-11-07 13:18:21 +01:00
Rainer Gerhards
d178cbf299 travis: fix invalid LLVM repository source 2017-11-07 12:06:50 +01:00
Rainer Gerhards
c45df26475 cleanup: reduce the number of warning-avoidance pragmas 2017-11-07 12:03:04 +01:00
Andre Lorbach
f9f99d90ef kafka: fixed multiple coverity scan issues 
CID 185720, 185719 fixed by correcting expression check for MsgFile handle.
CID 185723 fixed by removing CHKiRET
CID 185722 added additional check (stat) for MsgFile before unlink

Fixed 2 clang issues in imkafka as well
 2017-11-07 11:27:19 +01:00
Rainer Gerhards
8cb4e3b599
Merge pull request #1921 from rgerhards/travis-clang5-statan 
travis: use clang-5.0 for static analysis
 2017-11-07 08:37:43 +01:00
Stephen Workman
b2e7c05263 Add parse_time() RainerScript function. 2017-11-06 13:01:00 -05:00
Andre Lorbach
83f37b9a2b kafka: Fixed multiple issues found using clang 5.0 analyzer. 
Added some assert() calls to avoid false positives.
 2017-11-06 18:17:24 +01:00
Rainer Gerhards
d39492cb18 maintain ChangeLog 2017-11-06 17:32:46 +01:00
Rainer Gerhards
62fba10325
Merge pull request #1953 from jgerhards/46IPanon 
mmanon: add support for IPv6 wih embedded IPv4
 2017-11-06 17:30:17 +01:00
Jan Gerhards
ed1bfe36db mmanon: add support for IPv6 wih embedded IPv4 2017-11-05 17:53:15 +01:00
Art O Cathain
7f7784f5f1 Revert accidental whitespace changes 2017-11-05 16:40:33 +00:00
Rainer Gerhards
a56edb37f3
Merge pull request #1969 from rgerhards/cid-185322 
tcpsrv: fix potential memory leak on startup
 2017-11-05 17:14:40 +01:00
Rainer Gerhards
63d4e561d2
Merge pull request #1932 from rgerhards/race-1 
imdiag: fix cosmetic race in termination processing
 2017-11-05 17:13:00 +01:00
Rainer Gerhards
6d89c9cdbe imdiag: fix cosmetic race in termination processing 
This is not a real problem because imdiag intentionally does multiple
tries to validate predicate validity. However, this is reported in
clang thread sanitizer and so we need to fix it.
 2017-11-05 15:57:38 +01:00
Art O Cathain
ba0436eb63 Merge remote-tracking branch 'origin/master' into tls-client-sni 
# Conflicts:
#	tests/Makefile.am
 2017-11-05 14:55:57 +00:00
Rainer Gerhards
118f37e76c maintain ChangeLog 2017-11-05 15:47:56 +01:00
Rainer Gerhards
d21535636b
Merge pull request #1872 from rgerhards/i-1867 
imjournal: fixes and improvements
 2017-11-05 15:30:39 +01:00
Rainer Gerhards
27f96c84d3 imjournal bugfix: do not disable itself on error 
If some functions calls inside the main loop failed, imjournal exited
with an error code, actually disabling all logging from the journal.
This was probably never intended.

This patch makes imjournal recover the situation instead.

closes https://github.com/rsyslog/rsyslog/issues/1895
 2017-11-05 14:41:48 +01:00
Rainer Gerhards
82f9c4486e imjournal: refactor module, add more error messages 
Medium-Size refactoring. Could still need some more brush-up
but is in better shape than before.

closes https://github.com/rsyslog/rsyslog/issues/1868
 2017-11-05 14:41:48 +01:00
Rainer Gerhards
60accc74a2 imjournal cosmetic: use new-style LogMsg/LogError interface 2017-11-05 14:41:48 +01:00
Rainer Gerhards
9564267b71 imjournal: fix error message 
The return state was invalidly handled. Errno is not used by libjournal,
we need to use the return value to obtain error message.

see also https://github.com/rsyslog/rsyslog/issues/1867
 2017-11-05 14:41:48 +01:00
Rainer Gerhards
b8a9c014db tcpsrv: fix potential memory leak on startup 
small leak, can theoretically occur during rsyslog startup; will not
grow afterwards. Prime trigger would be out of process memory, which is
fatal in any case if it already occurs on startup.

Deteced by Coverity scan, CID 185322
 2017-11-05 12:46:54 +01:00
Rainer Gerhards
18262d01f1
Merge pull request #1965 from rgerhards/cid-185423 
file stream handler: ensure multiline read is kept valid
 2017-11-05 11:09:45 +01:00
Rainer Gerhards
e54e6f8f38
Merge pull request #1960 from rgerhards/185393 
ruleset: "fix" coverity scan issue
 2017-11-05 11:09:23 +01:00
Rainer Gerhards
0f65df6a12 exp: remove #pragma causing trouble with newer clang 2017-11-04 18:11:26 +01:00
Rainer Gerhards
1d83edab93 remove "clobbered" warning due to POSIX pthread_cancel_push() call 
Unfortuantely, the POSIX macro is not clean and so causes compilation
issues.
 2017-11-04 17:13:26 +01:00
Rainer Gerhards
6f0b2f7524 travies: use clang-5.0 for static analysis 2017-11-04 17:13:26 +01:00
Rainer Gerhards
1ab41dc28f
Merge pull request #1967 from rgerhards/clobbered 
build: remove #pragmas which can cause build issues
 2017-11-04 17:12:42 +01:00
Rainer Gerhards
167c57f17e build: remove #pragmas which can cause build issues 2017-11-04 15:28:41 +01:00
Rainer Gerhards
b0d9c79b89 ruleset: "fix" coverity scan issue 
while the issue is valid, this was not a bug but rather a
safeguard. Doing it slightly differntly this time.

CID 185393
 2017-11-03 19:19:10 +01:00
Rainer Gerhards
a71913029e file stream handler: ensure multiline read is kept valid 
We ensure that the previous line segment is always valid... actually this
was already done with existing code, but Coverity scan did not detect this.
Maybe we now get a control flow issue because we do what already happened
in this case...

CID 185423
 2017-11-03 19:01:13 +01:00
Rainer Gerhards
1c8d251d83 maintain ChangeLog 2017-11-03 18:34:46 +01:00
Rainer Gerhards
4a9fdf172a
Merge pull request #1958 from rgerhards/cid-185378 
core/net: potential memory leak when adding AllowedSenders
 2017-11-03 18:34:08 +01:00
Rainer Gerhards
6b42e3cf86
Merge pull request #1957 from PascalWithopf/i-1920 
Segfault when variable path consists of variables
 2017-11-03 18:31:53 +01:00
Rainer Gerhards
355a9f32f2 core/net: potential memory leak when adding AllowedSenders 
This is a small static leak that happens during config reading. At
most one leak for each configured but invalid allowed sender.

Detectec by Coverity scan, CID 185378
 2017-11-02 17:46:42 +01:00
PascalWithopf
c7a5085a7e Segfault when variable path consists of variables 
When no variables exist and a variable with at least one variable in its path was used, then rsyslog was searching for that non existant variable
Rsyslog now aborts it when no variables exist.
closes https://github.com/rsyslog/rsyslog/issues/1920
 2017-11-02 17:38:25 +01:00
Rainer Gerhards
de4ccbffe2
Merge pull request #1952 from rgerhards/cid-185422 
Coverity scan inspired patches
 2017-11-02 17:27:30 +01:00
Rainer Gerhards
1a9cc3605f imptcp: "fix" Coverity scan false positive 
CID 185421
 2017-11-02 13:08:18 +01:00
Rainer Gerhards
debeb5d9cb gcry crypto provider: fix potential NULL pointer addressing 
happens only during out of memory condition

Detected by Coverity scan, CID 185422
 2017-11-02 13:01:50 +01:00
Rainer Gerhards
0e49683db8 Merge branch 'master' of https://github.com/rsyslog/rsyslog 2017-11-02 10:43:38 +01:00
Rainer Gerhards
c7592dfe89 Merge pull request #1951 from rgerhards/coverity-10 
another set of Coverity scan inspired patches
 2017-11-02 10:43:27 +01:00