Rainer Gerhards
422061984f
omhiredis: fix Coverity scan cosmetic CID 185874
2017-11-27 12:55:25 +01:00
Rainer Gerhards
f466d4f2c4
omampq1: make build cleanly under gcc-7
2017-11-25 15:49:05 +01:00
Rainer Gerhards
2368cbfea5
omzmq3: fix gcc-7 build warnings
...
closes https://github.com/rsyslog/rsyslog/issues/2096
2017-11-25 10:42:51 +01:00
Rainer Gerhards
9d572f1172
imzmq3: fix gcc-7 build warnings
2017-11-25 10:41:42 +01:00
Rainer Gerhards
0704ef2439
[io]mzmq3: deprecate modules
...
closes https://github.com/rsyslog/rsyslog/issues/2100
2017-11-25 10:38:25 +01:00
Rainer Gerhards
e88605f76d
Merge pull request #2083 from jgerhards/errmsg-imczmq
...
imczmq: use new errmsg interface
2017-11-22 17:36:24 +01:00
Rainer Gerhards
719dcd0ff0
Merge pull request #2081 from jgerhards/errmsg-imzmq3c
...
imzmq3: use new errmsg interface
2017-11-22 16:16:55 +01:00
Jan Gerhards
f2cc076e5b
imczmq: use new errmsg interface
2017-11-22 14:39:28 +01:00
Jan Gerhards
d546fb4779
omtcl: use new errmsg interface
2017-11-22 14:35:36 +01:00
Jan Gerhards
8bc6628f2c
imzmq3: use new errmsg interface
2017-11-22 14:26:13 +01:00
Rainer Gerhards
9aa41d515a
"fix" Coverity scan false positives
...
plus some mild refactoring while we are at it
2017-11-22 11:16:17 +01:00
Rainer Gerhards
a4c7f2ac81
module-template framework: avoid compiler warning in some legal cases
...
the finalize_it: label is required, but not always used, which each
time results in a compiler warning that needs to be worked around.
Now this is fixed once and for all for gcc and clang - the others
will probably not complain in any case. Great solution until something
comes up that makes us need a revision.
2017-11-22 11:08:34 +01:00
Rainer Gerhards
338e09cd09
"fix" Coverity scan false positive CID 185398
2017-11-22 08:38:58 +01:00
Jan Gerhards
bf1476d81a
omczmq: : use new errmsg interface
2017-11-15 13:08:41 +01:00
PascalWithopf
e485c5c5bc
codestyle: shorten lines to max 130 chars
2017-11-15 09:04:42 +01:00
Rainer Gerhards
5e4c97639f
mmgrok: fix readme
...
Needs libfastjson, would segfault if build with json-c. Probably not updated since this changed.
2017-11-10 21:41:22 +01:00
Nachiketa Prachanda
666d2e1ce9
imczmq: remove unallocated and unused pointer
...
Fix a SIGSEGV in a call to
371: zcert_destroy(&serverCert) called from rcvData().
- remove serverCert as it is only used uninitialized in a call
to zcert_destroy() - this causes a core dump at rsyslogd exit.
- also initialize authActor at definition.
Signed-off-by: Nachiketa Prachanda <nachiketa.prachanda@att.com>
2017-10-31 14:01:30 -07:00
Rainer Gerhards
62dc5120f2
omhttpfs: flag Coverity-scan detected issue as intentional
2017-10-29 10:20:43 +01:00
Rainer Gerhards
e57638475b
mmcount: remove useless code
...
detected by Coverity scan, CID 185379
2017-10-29 10:17:06 +01:00
Rainer Gerhards
1837a3d54a
imczmq: remove never-reached code
...
This code was not required (handled by framework) and also never
reached.
Detected by Coverty Scan - CID 18543.
2017-10-27 13:19:51 +02:00
Rainer Gerhards
2fdb11657a
imczmq: fix potential memory leak
...
detected by clang static analyzer
2017-10-23 14:42:57 +02:00
Rainer Gerhards
6ef6ed8039
imczmq: fix additional compiler warnings
2017-10-23 14:19:51 +02:00
Rainer Gerhards
a9eb096182
Merge pull request #1887 from rgerhards/fix-0mq
...
0mq modules: fix compiler warnings
2017-10-23 14:01:18 +02:00
Rainer Gerhards
f39e6d33d8
0mq modules: fix compiler warnings
2017-10-23 12:13:45 +02:00
Rainer Gerhards
bbb81e1a60
mmcount: fix compiler warning
2017-10-23 10:18:40 +02:00
Jan Gerhards
516061e81d
mmcount: fix compiler warning
...
closes https://github.com/rsyslog/rsyslog/issues/1790
2017-10-22 17:53:25 +02:00
PascalWithopf
2f40554acb
codestyle: correct too long lines
2017-06-29 09:28:21 +02:00
Shane Lawrence
ed5ea46a65
Fix mangled pmsnare messages when tabs not escaped.
2017-06-05 11:44:11 -04:00
Rainer Gerhards
062d0c671a
Merge pull request #1565 from Whissi/fix-format-security-issue-in-zmq-modules
...
Fix format security issue in zmq3 modules
2017-06-01 15:39:40 +02:00
Rainer Gerhards
aecdbdf360
mmdblookup: upgrade from contrib module to fully supported one
2017-05-31 13:43:05 +02:00
Rainer Gerhards
435978f9b4
mmdblookup: permit to specify container for extracted fields
2017-05-31 13:43:05 +02:00
Rainer Gerhards
cc65f25f90
mmdblookup: permit to specify custom var names
...
... for database fields
2017-05-31 13:43:05 +02:00
Rainer Gerhards
0e9c6547f6
mmdblookup: simplify code && remove path size bug
...
We use code already present in rsyslog core. Also, the max
path size was hardcoded at 5/10 elements. While there is little
reason more could be used, if so, the module had misadressing
errors.
2017-05-31 13:43:05 +02:00
Rainer Gerhards
387c60eec3
mmdblookup: fix yet another memory leak
...
this happened when multi-level field names were used
2017-05-31 13:43:05 +02:00
Rainer Gerhards
8a5a62fd5c
testbench: cleanup & move kafka test to new style config
2017-05-31 13:43:05 +02:00
Rainer Gerhards
1b4762f68b
Merge pull request #1580 from rgerhards/i-600
...
bugfix: handling of json "null" objects in regard to msgGetJSONPropJSON
2017-05-29 14:38:03 +02:00
Rainer Gerhards
59565657c0
bugfix: handling of json "null" objects in regard to msgGetJSONPropJSON
...
libfastjson returns NULL for json "null" objects, and callers need
to handle this. This is correctly handled in almost all code path
in rsyslog, and this patch fixes theoretical issues in the remaining
two places. Note, however, that a json null object can not really
occur at those places due to the rest of processing. But we
wanted to include the check anyways.
closes https://github.com/rsyslog/rsyslog/issues/600
2017-05-23 16:23:40 +02:00
Brian Knox
691f8389dc
fix omhiredis build warnings
2017-05-23 09:13:15 -04:00
Rainer Gerhards
9e848478d0
Merge pull request #1575 from rgerhards/i-1415
...
mmdblookup bugfix: multiple memory leaks
2017-05-22 14:13:20 +02:00
Rainer Gerhards
0407bc8276
mmdblookup bugfix: multiple memory leaks
...
There were multiple large memory leaks in mmdblookup, which made
it unusable when used more than lightly.
closes https://github.com/rsyslog/rsyslog/issues/1415
2017-05-19 17:26:22 +02:00
Thomas Deutschmann
3f8a235d17
omzmq3: Fix building with -Werror=format-security
2017-05-17 23:07:40 +02:00
Thomas Deutschmann
6bc4aa975a
imzmq3: Fix building with -Werror=format-security
2017-05-17 23:05:24 +02:00
Rainer Gerhards
3ac9051b12
cosmetic: build system still used JSON_C name
...
... but used it for libfastjson. This was a left-over when we
could use both json-c and libfastjson. As github user hdatma
pointed out, this was confusing to users. This has now been
changed to LIBFASTJSON. No functional changes.
2017-05-16 11:05:57 +02:00
Luca Boccassi
75d5e6ff9e
imczmq: if topic is empty subscribe to everything
...
ZMQ_SUB supports subscribing to every topic, and it's indicated by an
empty string being passed as a topic.
Fix the config parsing to correctly interpret an empty string passed as
a parameter.
This fixes a regression introduced in 8.19 by commit:
299f5a637f97d2ec064ad3df20fa845ef4b7c7e5
2017-03-09 20:17:46 +00:00
Luca Boccassi
8ec2edc638
imczmq: do not set SUB/DISH sockets as serverish
...
By default it makes sense for ZMQ_SUB and ZMQ_DISH sockets to
connect, as that's the most common use case, unless specified by the
endpoint syntax.
Regression introduced in 8.19 by commit 299f5a637f97d2ec064ad3df20fa8
2017-03-09 20:13:15 +00:00
Rainer Gerhards
e318309c61
Merge pull request #1357 from GrayTShirt/mmdb-stylecheck
...
mmdblookup module cleanup
2017-01-23 15:37:49 +01:00
Pascal Withopf
b63a6b9010
codestyle: line length adjusted
2017-01-17 08:54:37 +01:00
Dan Molik
591eb7dbc2
Compile ip-lookup module during testing
...
- fix clang compilation by switching to BEGINdoAction_nostring
2017-01-13 13:41:52 -05:00
Dan Molik
6a4b10d861
Cleanup mmdb lookup readme
2017-01-13 08:59:36 -05:00
Dan Molik
f6451bb20b
mmdblookup - fix building
...
- minor coding style issues.
- fix compiler warnings
* string const
* function prototype
- fix compiler error, msg_t -> smsg_t
- fix libfastjson function deprecation.
- drop libjson environments file, as it is extraneous.
2017-01-12 16:57:24 -05:00