1426 Commits

Author SHA1 Message Date
Rainer Gerhards
5b4192519a omelasticsearch: fix memory leak and potential misadressing
Commit 96b5fce introduced regressions, leading to potential misadressing
and a very probable memory leak. This commit fixes the issues and
hardens the module to better detect some error cases in the
future.

It also adds valgrind-based testbench tests which ensure that no
pointer errors exist. If they had been in place, the regressions
would never have been undetected.

Note that commit 96b5fce was introduced in 8.23.0 on Nov, 15th 2016.

Many thanks to Yaroslav Bo for alerting me on the root problem and
providing a very good analysis and guidance.

see also https://github.com/rsyslog/rsyslog/issues/1906
closes https://github.com/rsyslog/rsyslog/issues/1962
see also https://github.com/rsyslog/rsyslog/issues/1964
2017-11-12 12:12:32 +01:00
Jan Gerhards
e71f72c272 mmanon: enable tests on FreeBSD
closes https://github.com/rsyslog/rsyslog/issues/2017
2017-11-11 18:40:38 +01:00
Rainer Gerhards
bd30e9c8ea
Merge pull request #2014 from rgerhards/i-1822bis
core/msg: fix segfault in MsgSetPropsViaJSON
2017-11-11 14:29:30 +01:00
Rainer Gerhards
67260eee4a testbench: add tests for segfault in MsgSetPropsViaJSON
Test for the root problem fixed in previous commit.

See also https://github.com/rsyslog/rsyslog/issues/1822
2017-11-11 10:24:45 +01:00
Rainer Gerhards
041f1c8f2e
Merge pull request #1990 from rgerhards/testbench-threaddebug
testbench: add threading correctness dynamic tests
2017-11-11 10:13:59 +01:00
Rainer Gerhards
2f76d61821 testbench: add threading correctness dynamic tests
utilizing the valgrind helgrind debugger

closes https://github.com/rsyslog/rsyslog/issues/1971
see also https://github.com/rsyslog/rsyslog/issues/2012
2017-11-10 19:03:01 +01:00
Rainer Gerhards
d413df23d2 testbench: add valgrind-test for imjournal 2017-11-10 14:13:09 +01:00
Hugo SOSZYNSKI
263796f2f2 Merge remote-tracking branch 'upstream/master' 2017-11-10 14:02:10 +01:00
Hugo SOSZYNSKI
7d3a2e61ab Now installing mongo-c-driver from the git on Travis. Corrected misunterstood structure initialisation by clang. Added the removed libmongo-client needed for the usertools. 2017-11-10 13:59:43 +01:00
Rainer Gerhards
c13bbe60c0 testbench: update zookeeper version used in tests
unfortunately, there is no generic URL available...
2017-11-09 19:51:01 +01:00
Rainer Gerhards
1ca0f3d776 testbench: detect and report error download kafka dependency
make sure we are not puzzled when things go wrong.
2017-11-09 18:14:30 +01:00
Rainer Gerhards
39c3c4bd59 testbench: run gdb in batch mode, nicer diagnostic output 2017-11-08 11:27:19 +01:00
Rainer Gerhards
d49880b843 testbench: provide easier to read core dump analysis 2017-11-08 11:27:19 +01:00
Rainer Gerhards
d65dc24616
Merge pull request #1925 from mrworkman/rscript-parse-time
Add RainerScript parse_time() function to convert date/time strings to UNIX time.
2017-11-08 08:38:56 +01:00
Rainer Gerhards
0a76796351
Merge pull request #1984 from jvymazal/librelp_CI
remove incorrect action option from testsuite conf
2017-11-08 08:21:40 +01:00
Jiri Vymazal
c091ac8164 remove incorrect action option from testsuite conf 2017-11-07 14:28:03 +01:00
Stephen Workman
2c2679ff12 Add comments for clarity. 2017-11-07 08:24:56 -05:00
Rainer Gerhards
6762c9907d CI: add ability to activate extra modules for static analysis 2017-11-07 13:22:02 +01:00
Rainer Gerhards
d178cbf299 travis: fix invalid LLVM repository source 2017-11-07 12:06:50 +01:00
Rainer Gerhards
8cb4e3b599
Merge pull request #1921 from rgerhards/travis-clang5-statan
travis: use clang-5.0 for static analysis
2017-11-07 08:37:43 +01:00
Stephen Workman
b2e7c05263 Add parse_time() RainerScript function. 2017-11-06 13:01:00 -05:00
Rainer Gerhards
62fba10325
Merge pull request #1953 from jgerhards/46IPanon
mmanon: add support for IPv6 wih embedded IPv4
2017-11-06 17:30:17 +01:00
Jan Gerhards
ed1bfe36db mmanon: add support for IPv6 wih embedded IPv4 2017-11-05 17:53:15 +01:00
Art O Cathain
7f7784f5f1 Revert accidental whitespace changes 2017-11-05 16:40:33 +00:00
Art O Cathain
ba0436eb63 Merge remote-tracking branch 'origin/master' into tls-client-sni
# Conflicts:
#	tests/Makefile.am
2017-11-05 14:55:57 +00:00
Rainer Gerhards
6f0b2f7524 travies: use clang-5.0 for static analysis 2017-11-04 17:13:26 +01:00
Hugo SOSZYNSKI
e10949041e Changed the libmogo-client-dev for libmongoc-driver-dev in the install.sh for Travis. 2017-11-03 09:04:07 +01:00
PascalWithopf
c7a5085a7e Segfault when variable path consists of variables
When no variables exist and a variable with at least one variable in its path was used, then rsyslog was searching for that non existant variable
Rsyslog now aborts it when no variables exist.
closes https://github.com/rsyslog/rsyslog/issues/1920
2017-11-02 17:38:25 +01:00
Rainer Gerhards
1319e63964
Merge pull request #1912 from rgerhards/ci-fix-merge
testbench: make sure try_merge does not fail because of git settings
2017-10-31 10:32:37 +01:00
Rainer Gerhards
a4e4d2ef34 testbench: make sure try_merge does not fail because of git settings 2017-10-30 18:30:56 +01:00
Rainer Gerhards
93d5f44ec1 CI: make sure clang static analyzer run is complete
As we cannot check both compiler and analyzer results -Werror might
cause incomplete analyzer run (and has done so in the past). To
ensure the analyzer step is always run completely, we disable -Werror.
2017-10-28 10:52:10 +02:00
Rainer Gerhards
6fc78e9d06 CI: consistenly use clang 5.0 for static analyzer builds 2017-10-27 17:46:19 +02:00
Rainer Gerhards
53c0aaed87 Merge pull request #1902 from PascalWithopf/freebsd_tests
freeBSD: disable tests that are not working
2017-10-27 13:18:48 +02:00
PascalWithopf
bd8a1b8136 freeBSD: disable tests that are not working
FreeBSD is not able to run all tests, therefore all tests that can't be run will be disabled.
2017-10-27 12:18:59 +02:00
Rainer Gerhards
87a831d6e1 Merge pull request #1901 from PascalWithopf/imudp_address_error
imudp: add error msg when listener wasn't created
2017-10-26 09:40:37 +02:00
Rainer Gerhards
bf9fd03639 testbench: implement basic test for imjournal
this ensures that the module is at least loading and doing
part of its work.

see also https://github.com/rsyslog/rsyslog/issues/1895
closes https://github.com/rsyslog/rsyslog/issues/164
2017-10-26 08:47:29 +02:00
PascalWithopf
aaa4f76721 imudp: add test for new error msg
Adds a test for the new error message when a listener could not be created.
2017-10-25 15:22:47 +02:00
PascalWithopf
03a5c4332b omrelp: add test for certificate check
Test checks that there is no Segmentation Fault when a certificate cannot be accessed.
2017-10-25 11:48:13 +02:00
Rainer Gerhards
8feb529984 CI: use clang 5.0 for static analyzer 2017-10-24 11:23:29 +02:00
Rainer Gerhards
cc3b61bfaa CI: add script to run static analyzer 2017-10-23 14:04:57 +02:00
Rainer Gerhards
9015b45c1e travis: enable building mmcount
while it is "just" a contributed module, we should make sure it
builds at least

closes https://github.com/rsyslog/rsyslog/issues/1879
2017-10-23 10:18:36 +02:00
Rainer Gerhards
f4f53b06eb Merge pull request #1859 from rgerhards/i-1832
omfile: hande file open error via SUSPEND mode
2017-10-19 13:34:39 +02:00
Rainer Gerhards
b85f2cc6d5 Merge pull request #1857 from rgerhards/i-1122
core bugfix: potential segfault when shutting down rsyslog
2017-10-19 13:33:18 +02:00
Rainer Gerhards
c503c70913 Merge pull request #1855 from rgerhards/i-1838
fix imgssapi
2017-10-19 11:14:09 +02:00
Rainer Gerhards
f4540ec6d6 build: remove compiler warnings from testbench tool syslog_caller 2017-10-18 12:45:03 +02:00
Rainer Gerhards
75ed9c0955 omfile: hande file open error via SUSPEND mode
For a while, this lead to suspension as the data error was
not detected by the rule engine. This has changed with fixes
in 8.30.0. I asked users what they prefer (and expect) and
everyone meant it should still be handled via suspension. See
github tracker below for more details.

closes https://github.com/rsyslog/rsyslog/issues/1832
2017-10-18 11:34:07 +02:00
Rainer Gerhards
4b564e760a testbench: add test for nested ruleset termination
see also https://github.com/rsyslog/rsyslog/issues/1122
2017-10-18 11:08:42 +02:00
Rainer Gerhards
2fd3fcca1e travis: remove temporary package override
this was needed while libfastjson 0.99.7 was not released
We just uncomment it so that the override can be easily re-enabled
the next time a similar need arises (what routinely happens)

closes https://github.com/rsyslog/rsyslog/issues/1848
2017-10-18 08:20:22 +02:00
Rainer Gerhards
07ea27a2e6 travis: enable build of gssapi components 2017-10-18 08:07:39 +02:00
Rainer Gerhards
c0b80d8756 testbench: harden tests against hanging previous instances
cleaning at exit does not always work because it sometimes is
not reached, especially in cases that go really wrong
2017-10-17 10:27:48 +02:00