mirror of
https://github.com/rsyslog/rsyslog.git
synced 2026-06-19 22:12:56 +02:00
Andre Lorbach
cd85debac0
Why: Enable CI validation on ARM architectures so platform-specific regressions are caught before merge. arm64 uses native GitHub runners; armhf uses QEMU because GitHub does not offer 32-bit ARM runners. Network namespace tests may fail under QEMU where the mount syscall is not properly emulated. Impact: - New arm_CI job runs on armhf and arm64 when relevant files change. - arm64 uses native ubuntu-24.04-arm runner; armhf uses QEMU on x64. - Netns tests skip gracefully (exit 77) if ip netns add fails. Before: - No ARM CI; netns tests could fail with cryptic errors under QEMU. After: - arm_CI: armhf (QEMU, reduced test set) and arm64 (native, expanded tests, ASan). - require_netns_capable() in diag.sh; netns tests call it and skip when unavailable. - ratelimit double-free fixed in ratelimit.c. - skip_ASAN() in diag.sh; empty-hostname, omfile-read-only* skip when ASan enabled (LD_PRELOAD/read-only behavior conflicts). Technical Overview: - Add arm_CI job to run_checks.yml: matrix over armhf/arm64. armhf: runs-on ubuntu-24.04, QEMU + Docker Buildx, reduced configure (disable-default-tests, many modules disabled). arm64: runs-on ubuntu-24.04-arm (native), expanded configure (default tests, gnutls, relp, imfile, etc.). Conditional QEMU setup only for armhf. - Add devtools/ci/Dockerfile.arm: Ubuntu 24.04 with build tools, gnutls, libestr, libfastjson, zlib, iproute2, libgcrypt, librelp, uuid, libyaml (for arm64 expanded build). - Add require_netns_capable() to diag.sh; use in imtcp-netns.sh, uxsock_multiple_netns.sh, tcp_forwarding_ns_tpl.sh. - Add skip_ASAN() to diag.sh; use in empty-hostname.sh, omfile-read-only.sh, omfile-read-only-errmsg.sh. - Add devtools/ci/Dockerfile.arm to arm_CI changed-files filter. - Quote $GITHUB_OUTPUT and $GITHUB_STEP_SUMMARY in clang static analyzer steps. - Fix double-free in ratelimit.c: shared->name is the hashtable key, freed by hashtable_destroy; remove redundant free(shared->name) in ratelimitFreeShared.
31 lines
1.2 KiB
Bash
Executable File
31 lines
1.2 KiB
Bash
Executable File
#!/bin/bash
|
|
# This tests checks for a anomaly we have seen in practice:
|
|
# gethostname() may return an empty string as hostname (""). This broke
|
|
# some versions of rsyslog, newer ones return "localhost" in that case.
|
|
# The test is done with the help of a preload library specifically written
|
|
# for this purpose (liboverride_gethostname.so). It will override
|
|
# gethostname() and return an empty string. Then, the test checks if the
|
|
# hardcoded default of "localhost-empty-hostname" is used.
|
|
# Note that the test may fail if the library is not properly preloaded.
|
|
# This is part of the rsyslog testbench, licensed under ASL 2.0
|
|
. ${srcdir:=.}/diag.sh init
|
|
skip_platform "AIX" "we cannot preload required dummy lib"
|
|
skip_ASAN "LD_PRELOAD conflicts with ASan runtime load order"
|
|
generate_conf
|
|
add_conf '
|
|
action(type="omfile" file=`echo $RSYSLOG_OUT_LOG`)
|
|
'
|
|
export RSYSLOG_PRELOAD=.libs/liboverride_gethostname.so
|
|
startup
|
|
shutdown_when_empty # shut down rsyslogd when done processing messages
|
|
wait_shutdown # we need to wait until rsyslogd is finished!
|
|
|
|
grep " localhost-empty-hostname " < $RSYSLOG_OUT_LOG
|
|
if [ ! $? -eq 0 ]; then
|
|
echo "expected hostname \"localhost-empty-hostname\" not found in logs, $RSYSLOG_OUT_LOG is:"
|
|
cat $RSYSLOG_OUT_LOG
|
|
error_exit 1
|
|
fi;
|
|
|
|
exit_test
|