mirror of
https://github.com/rsyslog/rsyslog.git
synced 2026-06-19 19:52:55 +02:00
Andre Lorbach
cd85debac0
Why: Enable CI validation on ARM architectures so platform-specific regressions are caught before merge. arm64 uses native GitHub runners; armhf uses QEMU because GitHub does not offer 32-bit ARM runners. Network namespace tests may fail under QEMU where the mount syscall is not properly emulated. Impact: - New arm_CI job runs on armhf and arm64 when relevant files change. - arm64 uses native ubuntu-24.04-arm runner; armhf uses QEMU on x64. - Netns tests skip gracefully (exit 77) if ip netns add fails. Before: - No ARM CI; netns tests could fail with cryptic errors under QEMU. After: - arm_CI: armhf (QEMU, reduced test set) and arm64 (native, expanded tests, ASan). - require_netns_capable() in diag.sh; netns tests call it and skip when unavailable. - ratelimit double-free fixed in ratelimit.c. - skip_ASAN() in diag.sh; empty-hostname, omfile-read-only* skip when ASan enabled (LD_PRELOAD/read-only behavior conflicts). Technical Overview: - Add arm_CI job to run_checks.yml: matrix over armhf/arm64. armhf: runs-on ubuntu-24.04, QEMU + Docker Buildx, reduced configure (disable-default-tests, many modules disabled). arm64: runs-on ubuntu-24.04-arm (native), expanded configure (default tests, gnutls, relp, imfile, etc.). Conditional QEMU setup only for armhf. - Add devtools/ci/Dockerfile.arm: Ubuntu 24.04 with build tools, gnutls, libestr, libfastjson, zlib, iproute2, libgcrypt, librelp, uuid, libyaml (for arm64 expanded build). - Add require_netns_capable() to diag.sh; use in imtcp-netns.sh, uxsock_multiple_netns.sh, tcp_forwarding_ns_tpl.sh. - Add skip_ASAN() to diag.sh; use in empty-hostname.sh, omfile-read-only.sh, omfile-read-only-errmsg.sh. - Add devtools/ci/Dockerfile.arm to arm_CI changed-files filter. - Quote $GITHUB_OUTPUT and $GITHUB_STEP_SUMMARY in clang static analyzer steps. - Fix double-free in ratelimit.c: shared->name is the hashtable key, freed by hashtable_destroy; remove redundant free(shared->name) in ratelimitFreeShared.
50 lines
1.6 KiB
Bash
Executable File
50 lines
1.6 KiB
Bash
Executable File
#!/bin/bash
|
|
# Test named rate limits for imtcp and imptcp
|
|
# This test defines a rate limit policy and applies it to listeners.
|
|
. ${srcdir:=.}/diag.sh init --suppress-abort-on-error
|
|
skip_ARM "ratelimit timing flaky on ARM"
|
|
export NUMMESSAGES=10
|
|
export QUEUE_EMPTY_CHECK_FUNC=wait_file_lines
|
|
generate_conf
|
|
add_conf '
|
|
ratelimit(name="test_limit" interval="2" burst="5")
|
|
|
|
module(load="../plugins/imtcp/.libs/imtcp")
|
|
input(type="imtcp" port="0" listenPortFileName="'$RSYSLOG_DYNNAME'.tcp.port" ratelimit.name="test_limit")
|
|
|
|
module(load="../plugins/imptcp/.libs/imptcp")
|
|
input(type="imptcp" port="0" listenPortFileName="'$RSYSLOG_DYNNAME'.ptcp.port" ratelimit.name="test_limit")
|
|
|
|
template(name="outfmt" type="string" string="%msg%\n")
|
|
action(type="omfile" file="'$RSYSLOG_OUT_LOG'" template="outfmt")
|
|
'
|
|
startup
|
|
# Send messages to TCP port
|
|
tcp_port=$(cat $RSYSLOG_DYNNAME.tcp.port)
|
|
./tcpflood -p$tcp_port -m 20
|
|
# Send messages to PTCP port
|
|
ptcp_port=$(cat $RSYSLOG_DYNNAME.ptcp.port)
|
|
./tcpflood -p$ptcp_port -m 20
|
|
|
|
shutdown_when_empty
|
|
wait_shutdown
|
|
|
|
# Check if messages were rate limited (we sent 20, burst is 5, interval 2s)
|
|
# We expect some loss.
|
|
content_count=$(grep -c "msgnum:" $RSYSLOG_OUT_LOG 2>/dev/null)
|
|
if [ -z "$content_count" ]; then
|
|
content_count=0
|
|
fi
|
|
echo "content_count: $content_count"
|
|
if [ $content_count -eq 40 ]; then
|
|
echo "FAIL: No rate limiting occurred (received all 40 messages)"
|
|
error_exit 1
|
|
fi
|
|
if [ $content_count -lt 10 ]; then
|
|
echo "FAIL: Too many messages lost (received $content_count)"
|
|
error_exit 1
|
|
fi
|
|
|
|
echo "SUCCESS: Rate limiting occurred (received $content_count/40)"
|
|
exit_test
|