mirror of
https://github.com/rsyslog/rsyslog.git
synced 2026-06-19 16:22:57 +02:00
1e80f70356
Why: Regular PR CI should avoid waking long-running service-backed tests when a change only touches unrelated helper code. Kafka, imfile, and Elasticsearch are frequent long-tail costs, so they need focused relevance gates without weakening full CI and flake-testing workflows. Impact: PR CI omits Kafka, imfile, and Elasticsearch tests for unrelated helper-only changes, while direct module/test changes and plausible shared runtime paths still run those families. Local CI-container runs can apply the same relevance policy before devtools/run-ci.sh. Before/After: Before, broad runtime patterns made these expensive families run too often; after, they use explicit focused dependency rules with full-run overrides. Technical Overview: Move the remaining root-level runtime C/H files under runtime/ so path-based rules can reason about core code consistently. Keep conservative broad relevance for service families that do not yet have focused dependency rules. Add focused relevance for Kafka, imfile, and Elasticsearch covering module paths, tests, build/testbench plumbing, config/message/action/queue, worker, template, ruleset, parser, stats, and selected family-specific runtime helpers. Keep isolated helpers such as lookup tables, dynstats, DNS cache, crypto/KSI, GSSAPI, and unrelated protocol helpers from waking those families. Add devtools/apply-service-relevance.sh so GitHub Actions and local container testing share the same relevance-to-configure suppression logic. Centralize Elasticsearch and Kafka job decisions on the top-level change-scope outputs so scheduled jobs always run their test body. Preserve RSYSLOG_TESTBENCH_FORCE_SERVICE_TESTS, RSYSLOG_TESTBENCH_FORCE_<MODULE>_TESTS, and RSYSLOG_TESTBENCH_SKIP_SERVICE_RELEVANCE so daily, weekly, and flake runs can still force all tests even when there are no relevant changes. Document that AI agents must validate both the relevance decision layer and the resulting configured test list when changing these gates. Validation: bash -n tests/diag.sh devtools/apply-service-relevance.sh git diff --check actionlint .github/workflows/run_checks.yml shellcheck -S warning devtools/apply-service-relevance.sh module-needs-testing rule matrix for kafka, imfile, elasticsearch, mysql Temporary git-diff probes for runtime/lookup.c and runtime/action.c Source helper checks for runtime/lookup.c and runtime/action.c Ubuntu 26.04 container make distclean plus MOCK-OK run-ci for runtime/lookup.c With the help of AI-Agents: Codex