mirror of
https://github.com/rsyslog/rsyslog.git
synced 2026-06-15 19:52:39 +02:00
1e3bef2f5b
Why: Agents often skip the mutating format step because it is not part of the regular deterministic local validation path. That lets formatting issues escape to review even when the local check helper is otherwise used. Impact: Changed C and header files are now checked by the local validation helper without rewriting files. Missing clang-format remains a warning, not a local workflow blocker. Before/After: Before, the local helper called the mutating formatter. After, it runs a clang-format dry-run check and keeps explicit formatting as a separate action. Technical Overview: Add --check and --check-if-available modes to devtools/format-code.sh. Use clang-format's dry-run and Werror mode for read-only validation. Extend the changed C/H file helper to include committed branch changes, staged and unstaged edits, and untracked C/H files. Pass the validation planner base ref into the format helper so both scripts classify the same delta. Document the workflow in AGENTS.md and the local validation/commit skills. Validation: - shellcheck devtools/format-code.sh devtools/list-git-changed-c-h-files.sh devtools/local-validation-plan.sh - checkbashisms -p devtools/local-validation-plan.sh - bash -n devtools/format-code.sh devtools/list-git-changed-c-h-files.sh - sh -n devtools/local-validation-plan.sh - devtools/local-validation-plan.sh --run - devtools/format-code.sh --git-changed --check --check-if-available - untracked C probe with devtools/list-git-changed-c-h-files.sh - untracked C probe with devtools/format-code.sh --git-changed --check --check-if-available - cubic review --print-logs --base origin/main With the help of AI-Agents: OpenAI Codex