rsyslog/rsyslog
1
0
Fork 0
mirror of https://github.com/rsyslog/rsyslog.git synced 2026-06-19 23:22:56 +02:00
Code Issues Packages Projects Releases Wiki Activity
rsyslog/runtime
History
Rainer Gerhards e0dc6d52a4 ratelimit: free dropped TCP messages on helper errors 
Why
The previous change kept TCP batch processing alive on ratelimit helper
errors, but it left message ownership with the caller in those error
paths. Continuing without cleanup leaks the message object.

Impact
Unexpected ratelimit helper errors now drop and free the current message
before processing continues.

Before/After
Before, non-discard helper errors could leak `pMsg` in imptcp and the
generic TCP session path. After, both paths destroy the unqueued message
before returning success to the caller.

Technical Overview
`ratelimitAddMsg()` and `ratelimitAddMsgPerSource()` only take ownership
of a message when they enqueue or explicitly discard it internally.
When they return an unexpected error, ownership remains with the caller.
Add `msgDestruct(&pMsg)` in the non-discard error branch for `imptcp`
and `tcps_sess`, and update the debug text to reflect that the message is
being dropped before batch processing continues.
This preserves the non-fatal caller behavior while closing the memory
leak identified by gemini-code-assist and cubic.

With the help of AI-Agents: Codex
2026-04-13 08:10:39 +02:00
..
hashtable
style: normalize C source formatting via clang-format (PoC)
2025-07-16 13:56:21 +02:00
AGENTS.md
docs(agents): add rsyslog_config skill and config parity guidance
2026-03-27 14:24:10 +01:00
atomic.h
runtime: clarify atomic helper usage
2026-01-29 17:17:38 +01:00
batch.h
style: normalize C source formatting via clang-format (PoC)
2025-07-16 13:56:21 +02:00
cfsysline.c
runtime: fix Darwin build regressions and improve BSD portability
2025-09-03 12:29:19 +02:00
cfsysline.h
style: normalize C source formatting via clang-format (PoC)
2025-07-16 13:56:21 +02:00
conf.c
style: normalize C source formatting via clang-format (PoC)
2025-07-16 13:56:21 +02:00
conf.h
style: normalize C source formatting via clang-format (PoC)
2025-07-16 13:56:21 +02:00
cryprov.h
style: normalize C source formatting via clang-format (PoC)
2025-07-16 13:56:21 +02:00
datetime.c
🛡️ Sentinel: Fix buffer overflow risk in datetime formatting
2026-02-04 16:50:11 +01:00
datetime.h
style: normalize C source formatting via clang-format (PoC)
2025-07-16 13:56:21 +02:00
debug.c
style: normalize C source formatting via clang-format (PoC)
2025-07-16 13:56:21 +02:00
debug.h
style: normalize C source formatting via clang-format (PoC)
2025-07-16 13:56:21 +02:00
dnscache.c
core: expand checked literal copies across fixed buffers
2026-02-18 13:04:27 +01:00
dnscache.h
style: normalize C source formatting via clang-format (PoC)
2025-07-16 13:56:21 +02:00
dynstats.c
runtime: refactor dynstats meta-counter name assembly
2026-02-18 17:19:44 +01:00
dynstats.h
dynstats: add opt-in state persistence; fix worker lifecycle
2026-01-20 10:56:28 +01:00
errmsg.c
core: add doxygen comments to errmsg object
2025-09-13 10:27:30 +02:00
errmsg.h
core: fix LogError(0, ...) anti-pattern and add guidelines
2025-12-05 18:57:43 +01:00
glbl.c
Fix typos: corrected 'intial' to 'initial' and 'intialize' to 'initialize'
2025-10-30 12:17:03 +05:30
glbl.h
core: add setting to permit compact json format
2025-09-10 14:42:48 +02:00
gss-misc.c
style: normalize C source formatting via clang-format (PoC)
2025-07-16 13:56:21 +02:00
gss-misc.h
style: normalize C source formatting via clang-format (PoC)
2025-07-16 13:56:21 +02:00
hashtable_itr.c
style: normalize C source formatting via clang-format (PoC)
2025-07-16 13:56:21 +02:00
hashtable_itr.h
style: normalize C source formatting via clang-format (PoC)
2025-07-16 13:56:21 +02:00
hashtable_private.h
style: normalize C source formatting via clang-format (PoC)
2025-07-16 13:56:21 +02:00
hashtable.c
style: normalize C source formatting via clang-format (PoC)
2025-07-16 13:56:21 +02:00
hashtable.h
style: normalize C source formatting via clang-format (PoC)
2025-07-16 13:56:21 +02:00
im-helper.h
style: normalize C source formatting via clang-format (PoC)
2025-07-16 13:56:21 +02:00
janitor.c
style: normalize C source formatting via clang-format (PoC)
2025-07-16 13:56:21 +02:00
janitor.h
style: normalize C source formatting via clang-format (PoC)
2025-07-16 13:56:21 +02:00
lib_ksi_queue.c
style: normalize C source formatting via clang-format (PoC)
2025-07-16 13:56:21 +02:00
lib_ksi_queue.h
style: normalize C source formatting via clang-format (PoC)
2025-07-16 13:56:21 +02:00
lib_ksils12.c
style: normalize C source formatting via clang-format (PoC)
2025-07-16 13:56:21 +02:00
lib_ksils12.h
style: normalize C source formatting via clang-format (PoC)
2025-07-16 13:56:21 +02:00
libcry_common.c
style: normalize C source formatting via clang-format (PoC)
2025-07-16 13:56:21 +02:00
libcry_common.h
Refactor ossl crypto provider
2024-08-14 07:56:29 +02:00
libgcry.c
style: normalize C source formatting via clang-format (PoC)
2025-07-16 13:56:21 +02:00
libgcry.h
style: normalize C source formatting via clang-format (PoC)
2025-07-16 13:56:21 +02:00
libossl.c
style: normalize C source formatting via clang-format (PoC)
2025-07-16 13:56:21 +02:00
libossl.h
style: normalize C source formatting via clang-format (PoC)
2025-07-16 13:56:21 +02:00
librsksi_read.c
runtime/rsksi: check KSI_DataHash_extract return values
2025-12-25 17:58:37 +01:00
linkedlist.c
style: normalize C source formatting via clang-format (PoC)
2025-07-16 13:56:21 +02:00
linkedlist.h
style: normalize C source formatting via clang-format (PoC)
2025-07-16 13:56:21 +02:00
lmcry_gcry.c
style: normalize C source formatting via clang-format (PoC)
2025-07-16 13:56:21 +02:00
lmcry_gcry.h
build: normalize object prototypes and remove decl noise
2026-02-07 11:32:00 +01:00
lmcry_ossl.c
style: normalize C source formatting via clang-format (PoC)
2025-07-16 13:56:21 +02:00
lmcry_ossl.h
style: normalize C source formatting via clang-format (PoC)
2025-07-16 13:56:21 +02:00
lmsig_ksi-ls12.c
lmsig_ksi: remove unused REPORT_PARAM_MISSING macro
2026-01-06 13:22:17 +01:00
lmsig_ksi-ls12.h
build: normalize object prototypes and remove decl noise
2026-02-07 11:32:00 +01:00
lookup.c
Fix lookup table reload race condition (Device or resource busy)
2026-02-03 13:18:37 +01:00
lookup.h
style: normalize C source formatting via clang-format (PoC)
2025-07-16 13:56:21 +02:00
Makefile.am
Merge pull request #6679 from rgerhards/codex/config-translate-mode
2026-04-03 10:31:18 +02:00
module-template.h
core: Fix typos in comments
2026-03-16 23:40:43 -07:00
modules.c
core: Fix typos in comments
2026-03-16 23:40:43 -07:00
modules.h
core, runtime, omfwd: plumb action name into modules and logs
2026-01-01 12:04:29 +01:00
msg.c
build: normalize object prototypes and remove decl noise
2026-02-07 11:32:00 +01:00
msg.h
make mmutf8fix work also on tags
2026-01-17 13:14:00 +01:00
net_ossl.c
tls: add native post-quantum guidance and tests
2026-03-11 15:10:24 +01:00
net_ossl.h
build: normalize object prototypes and remove decl noise
2026-02-07 11:32:00 +01:00
net.c
core: expand checked literal copies across fixed buffers
2026-02-18 13:04:27 +01:00
net.h
net: Add NetworkNamespace APIs
2025-09-12 08:48:31 -07:00
netns_socket.c
net: Add NetworkNamespace APIs
2025-09-12 08:48:31 -07:00
netns_socket.h
net: Add NetworkNamespace APIs
2025-09-12 08:48:31 -07:00
netstrm.c
ossl: add OCSP certificate revocation checking support
2026-01-19 11:14:09 +01:00
netstrm.h
build: normalize object prototypes and remove decl noise
2026-02-07 11:32:00 +01:00
netstrms.c
ossl: add OCSP certificate revocation checking support
2026-01-19 11:14:09 +01:00
netstrms.h
build: normalize object prototypes and remove decl noise
2026-02-07 11:32:00 +01:00
nsd_gtls.c
gtls: check CRL expiration, reject connections with expired CRL
2026-03-24 13:39:28 +01:00
nsd_gtls.h
gtls: check CRL expiration, reject connections with expired CRL
2026-03-24 13:39:28 +01:00
nsd_mbedtls.c
build: normalize object prototypes and remove decl noise
2026-02-07 11:32:00 +01:00
nsd_mbedtls.h
build: normalize object prototypes and remove decl noise
2026-02-07 11:32:00 +01:00
nsd_ossl.c
build: normalize object prototypes and remove decl noise
2026-02-07 11:32:00 +01:00
nsd_ossl.h
build: normalize object prototypes and remove decl noise
2026-02-07 11:32:00 +01:00
nsd_ptcp.c
core: expand checked literal copies across fixed buffers
2026-02-18 13:04:27 +01:00
nsd_ptcp.h
build: normalize object prototypes and remove decl noise
2026-02-07 11:32:00 +01:00
nsd.h
ossl: add OCSP certificate revocation checking support
2026-01-19 11:14:09 +01:00
obj-types.h
build: normalize object prototypes and remove decl noise
2026-02-07 11:32:00 +01:00
obj.c
runtime: fix srUtilItoA() data type inconsistencies
2026-01-31 18:30:51 +01:00
obj.h
core: migrate callback invocations to type-safe signatures
2025-08-01 13:02:10 +02:00
objomsr.c
style: normalize C source formatting via clang-format (PoC)
2025-07-16 13:56:21 +02:00
objomsr.h
style: normalize C source formatting via clang-format (PoC)
2025-07-16 13:56:21 +02:00
operatingstate.c
style: normalize C source formatting via clang-format (PoC)
2025-07-16 13:56:21 +02:00
operatingstate.h
style: normalize C source formatting via clang-format (PoC)
2025-07-16 13:56:21 +02:00
parser.c
style: normalize C source formatting via clang-format (PoC)
2025-07-16 13:56:21 +02:00
parser.h
build: normalize object prototypes and remove decl noise
2026-02-07 11:32:00 +01:00
perctile_ringbuf.c
style: normalize C source formatting via clang-format (PoC)
2025-07-16 13:56:21 +02:00
perctile_ringbuf.h
style: normalize C source formatting via clang-format (PoC)
2025-07-16 13:56:21 +02:00
perctile_stats.c
style: normalize C source formatting via clang-format (PoC)
2025-07-16 13:56:21 +02:00
perctile_stats.h
style: normalize C source formatting via clang-format (PoC)
2025-07-16 13:56:21 +02:00
prop.c
style: normalize C source formatting via clang-format (PoC)
2025-07-16 13:56:21 +02:00
prop.h
build: normalize object prototypes and remove decl noise
2026-02-07 11:32:00 +01:00
queue.c
core: Fix typos in comments
2026-03-16 23:40:43 -07:00
queue.h
queue/runtime/tests: harden diskqueue recovery and shutdown race handling
2026-02-23 10:17:04 +01:00
ratelimit.c
ratelimit: watch YAML policy files with debounce
2026-04-08 08:45:24 +02:00
ratelimit.h
ratelimit: watch YAML policy files with debounce
2026-04-08 08:45:24 +02:00
regexp.c
runtime: call class exit on lib unload
2026-01-30 12:20:21 +01:00
regexp.h
style: normalize C source formatting via clang-format (PoC)
2025-07-16 13:56:21 +02:00
rsconf.c
rsconf: clarify stale loadConf comments
2026-04-12 13:12:54 +02:00
rsconf.h
build: normalize object prototypes and remove decl noise
2026-02-07 11:32:00 +01:00
rsyslog.c
Fix typos: corrected 'intial' to 'initial' and 'intialize' to 'initialize'
2025-10-30 12:17:03 +05:30
rsyslog.h
tls: add native post-quantum guidance and tests
2026-03-11 15:10:24 +01:00
ruleset.c
core: stop busy-loop when action disables itself
2025-12-05 16:44:11 +01:00
ruleset.h
build: normalize object prototypes and remove decl noise
2026-02-07 11:32:00 +01:00
sigprov.h
style: normalize C source formatting via clang-format (PoC)
2025-07-16 13:56:21 +02:00
srutils.c
runtime: harden TCP framing size handling
2026-04-09 19:27:09 +02:00
srUtils.h
omfile: pass size-limit file to rotate cmd
2026-01-28 14:02:39 +01:00
statsobj.c
impstats: add VictoriaMetrics push via Remote Write
2026-02-06 16:02:08 +01:00
statsobj.h
runtime: refactor dynstats meta-counter name assembly
2026-02-18 17:19:44 +01:00
stream.c
runtime: fix srUtilItoA() data type inconsistencies
2026-01-31 18:30:51 +01:00
stream.h
build: normalize object prototypes and remove decl noise
2026-02-07 11:32:00 +01:00
strgen.c
build: normalize object prototypes and remove decl noise
2026-02-07 11:32:00 +01:00
strgen.h
build: normalize object prototypes and remove decl noise
2026-02-07 11:32:00 +01:00
stringbuf.c
ci: enable imfile tests in ARM CI and fix arm64 fallout
2026-04-04 14:01:39 +02:00
stringbuf.h
style: normalize C source formatting via clang-format (PoC)
2025-07-16 13:56:21 +02:00
strms_sess.c
style: normalize C source formatting via clang-format (PoC)
2025-07-16 13:56:21 +02:00
strms_sess.h
style: normalize C source formatting via clang-format (PoC)
2025-07-16 13:56:21 +02:00
syslogd-types.h
style: normalize C source formatting via clang-format (PoC)
2025-07-16 13:56:21 +02:00
tcpclt.c
runtime: harden TCP framing size handling
2026-04-09 19:27:09 +02:00
tcpclt.h
build: normalize object prototypes and remove decl noise
2026-02-07 11:32:00 +01:00
tcps_sess.c
ratelimit: free dropped TCP messages on helper errors
2026-04-13 08:10:39 +02:00
tcps_sess.h
build: normalize object prototypes and remove decl noise
2026-02-07 11:32:00 +01:00
tcpsrv.c
runtime: harden TCP framing size handling
2026-04-09 19:27:09 +02:00
tcpsrv.h
core: Fix typos in comments
2026-03-16 23:40:43 -07:00
timezones.c
style: normalize C source formatting via clang-format (PoC)
2025-07-16 13:56:21 +02:00
timezones.h
style: normalize C source formatting via clang-format (PoC)
2025-07-16 13:56:21 +02:00
translate.c
runtime: harden YAML string-node OOM handling
2026-04-03 17:24:16 +02:00
translate.h
runtime: add config translation mode
2026-04-02 19:36:34 +02:00
typedefs.h
core: Fix typos in comments
2026-03-16 23:40:43 -07:00
unicode-helper.h
style: normalize C source formatting via clang-format (PoC)
2025-07-16 13:56:21 +02:00
unlimited_select.h
style: normalize C source formatting via clang-format (PoC)
2025-07-16 13:56:21 +02:00
var.c
style: normalize C source formatting via clang-format (PoC)
2025-07-16 13:56:21 +02:00
var.h
build: normalize object prototypes and remove decl noise
2026-02-07 11:32:00 +01:00
wti.c
core: Fix typos in comments
2026-03-16 23:40:43 -07:00
wti.h
runtime: fix race condition in worker thread startup
2026-01-06 11:34:36 +01:00
wtp.c
core: Fix typos in comments
2026-03-16 23:40:43 -07:00
wtp.h
atomic: remove trailing semicolons from helper macros
2025-08-19 16:06:44 +02:00
yamlconf.c
runtime: add config translation mode
2026-04-02 19:36:34 +02:00
yamlconf.h
feat: add YAML as an alternative configuration format
2026-03-26 09:19:48 +01:00
zlibw.c
core: Fix typos in comments
2026-03-16 23:40:43 -07:00
zlibw.h
style: normalize C source formatting via clang-format (PoC)
2025-07-16 13:56:21 +02:00
zstdw.c
runtime: call class exit on lib unload
2026-01-30 12:20:21 +01:00
zstdw.h
style: normalize C source formatting via clang-format (PoC)
2025-07-16 13:56:21 +02:00