11636 Commits

Author SHA1 Message Date
Rainer Gerhards
1d7e772088 core: replace some inline functions by macros
I consider the C99 semantics to be pretty broken. Rather than
duplicating code for the inline variant and the non-inline one,
I replace the functions in question by macros. We do not loose
much in terms of type-safety.

see also https://github.com/rsyslog/rsyslog/pull/2246
2017-12-18 12:40:34 +01:00
Rainer Gerhards
d999f0512e maintain ChangeLog 2017-12-18 12:35:50 +01:00
Rainer Gerhards
ca38c563e8
Merge pull request #2245 from rgerhards/i-2217
omhiredis bugfix: rsyslog segfault on startup if no template is speci…
2017-12-18 12:12:52 +01:00
Rainer Gerhards
4db63f339a
Merge pull request #2247 from mrworkman/fix-rscript-format-time-test
Fix test so it will run on FreeBSD.
2017-12-18 09:25:10 +01:00
Rainer Gerhards
5bd1daf647 omhiredis bugfix: rsyslog segfault on startup if no template is specified
closes https://github.com/rsyslog/rsyslog/issues/2217
2017-12-17 19:17:41 +01:00
Rainer Gerhards
1f11453dac maintain ChangeLog 2017-12-17 17:22:24 +01:00
Rainer Gerhards
2d2b6f8934
Merge pull request #2240 from jgerhards/i2232
mmanon: fix undefined behaviour
2017-12-17 17:21:50 +01:00
Rainer Gerhards
5ca1c707a1
Merge pull request #2239 from rgerhards/ubsan3
make UBSan not complain about questionable OS lib function
2017-12-17 17:21:17 +01:00
Rainer Gerhards
a8d4ed7803
Merge pull request #2238 from rgerhards/i-2236
omfile: add module-global option "dynafile.donotsuspend"
2017-12-17 17:17:59 +01:00
Jan Gerhards
a8c36ef4fd mmanon: fix undefined behaviour
closes https://github.com/rsyslog/rsyslog/issues/2232
2017-12-17 16:25:38 +01:00
Rainer Gerhards
d8de72fb9a make UBSan not complain about questionable OS lib function 2017-12-17 13:20:44 +01:00
Stephen Workman
d068170818 Fix test so it will run on FreeBSD. 2017-12-16 18:49:12 -05:00
Rainer Gerhards
e1758bf32c omfile: add module-global option "dynafile.donotsuspend"
this permits to enable SUSPENDing dynafile actions. Traditionally,
SUSPEND mode was never entered for dynafiles as it would have blocked
overall processing flow. Default is not to suspend (and thus block).

closes https://github.com/rsyslog/rsyslog/issues/2236
2017-12-16 18:32:58 +01:00
Rainer Gerhards
42228252a2
Merge pull request #2237 from rgerhards/disable-faketime2
testbench: fix new --enable-libfaketime configure option
2017-12-16 17:38:56 +01:00
Rainer Gerhards
8b99303b04
Merge pull request #2235 from rgerhards/i-2012
core: fix potential race
2017-12-16 17:34:18 +01:00
Rainer Gerhards
0d6b3d47f7 testbench: fix new --enable-libfaketime configure option
some tests requiring faketime were executed even when this was
disabled
2017-12-16 16:26:07 +01:00
Rainer Gerhards
835d6b104b
Merge pull request #2233 from rgerhards/i-2212
testbench: name valgrind tests consitently (end with -vg.sh)
2017-12-16 16:19:00 +01:00
Rainer Gerhards
2254fe214e core: fix potential race
This fixes a potential race that valgrind's helgrind found on some
very few occasions, and right now only on CentOS 7. However, it
looks like the variable was actually not correctly protected.

see also https://github.com/rsyslog/rsyslog/issues/2012
2017-12-16 14:24:12 +01:00
Rainer Gerhards
f6678ab4c3 maintain ChangeLog 2017-12-16 14:02:22 +01:00
Rainer Gerhards
7ecaa9aa3f
Merge pull request #2234 from rgerhards/disable-faketime
testbench: add a capability to turn off libfaketime tests via configure
2017-12-16 14:00:31 +01:00
Rainer Gerhards
78356cdf1b testbench: name valgrind tests consitently (end with -vg.sh)
closes https://github.com/rsyslog/rsyslog/issues/2212
2017-12-16 12:19:28 +01:00
Rainer Gerhards
47c7d824db testbench: add a capability to turn off libfaketime tests via configure
Unfortunately, libfaketime becomes more and more problematic in newer
versions and causes aborts on some platforms. This provides the ability
to turn it off via --disable-libfaketime.

In the longer term, we should consider writing our own replacement.
2017-12-16 11:39:15 +01:00
Rainer Gerhards
ac87ab0a71
Merge pull request #2226 from rgerhards/fix-imptcp_conndrop-vg
imptcp: check if we really got a remote addr on connect
2017-12-15 13:34:52 +01:00
Rainer Gerhards
f4b49978ea
Merge pull request #2225 from rgerhards/ubsan2
fixes to address UBSAN issues
2017-12-15 12:00:51 +01:00
Rainer Gerhards
5b6fc5d930 imptcp: check if we really got a remote addr on connect
CI testing seems to indicate that we sometimes do not get valid
data, but so far we could not reliably reproduce this. This commit
introduces an additional check which emits an error message in
that case. The hope is that we will see it on further occasions or
get some reports. If that really happens, we should handle it.
2017-12-15 11:29:54 +01:00
Rainer Gerhards
d863d6c19b timestamp parsing: do not permit years > 2100
root cause detected by clang UBSAN
2017-12-15 10:51:56 +01:00
Rainer Gerhards
e70620510e imuxsock: refactor
among others, makes it easier to spot errors in UBSAN runs
2017-12-15 09:51:16 +01:00
Rainer Gerhards
68a620fb5c fix potential unsigened integer overflow
should not have a bad impact on all current platforms, as the
result is properly casted. It's still a potential problem spot.

Detecec by clang UBSAN.
2017-12-15 09:35:39 +01:00
Rainer Gerhards
dd9b98986d core bugfix: inconsitent atomic fetch function interface
macro used unsigned, inline function int. This could lead to an unsigned
overflow if macro version was used. That could potentially lead to malfunction
on some platforms (not seen nor expected in practice, though).

Detected by clang UBSAN.
2017-12-15 09:28:05 +01:00
Rainer Gerhards
e20fa8f871
Merge pull request #2216 from rgerhards/i-2215
debug system: output global and imrelp (listener) max message size
2017-12-15 08:11:01 +01:00
Rainer Gerhards
ab01a94f04 maintain ChangeLog 2017-12-15 08:10:24 +01:00
Rainer Gerhards
2f49a078b2
Merge pull request #2223 from rgerhards/ubsan1
Ubsan1
2017-12-15 08:06:49 +01:00
Rainer Gerhards
29f9bf6068 core bugfix: undefined behavior due to integer overflow
when searching strings, we may have an (unsigned) interger overflow
which can lead to misadressing.

Detected by clang ubsan.
2017-12-14 18:49:04 +01:00
Rainer Gerhards
6d29ae4e31 ubsan: flag unsigned integer overflow as intentional 2017-12-14 18:48:59 +01:00
Rainer Gerhards
69661aac90 debug system: output global and imrelp (listener) max message size
Can be useful during debugging.

closes https://github.com/rsyslog/rsyslog/issues/2215
2017-12-14 18:37:30 +01:00
Rainer Gerhards
1e9579b544 core bugfix: potential segfault on startup
timezone info table was "sorted" even though it may be NULL

Detected by clang ubsan.
2017-12-14 17:25:17 +01:00
Rainer Gerhards
967f9de2eb
Merge pull request #2221 from rgerhards/cid-186292
pmrfc3164: fix invalid whitespace-skip
2017-12-14 17:17:47 +01:00
Rainer Gerhards
4ba1cc2e03
Merge pull request #2222 from jgerhards/errmsg-omzmq3
omzmq3: use new errmsg interface
2017-12-14 17:07:46 +01:00
Rainer Gerhards
48e151ea8f
Merge pull request #2219 from allanpark/Issue_2218_lmsig_ksils12_coverity_185331
Issue $2218: lmsig_ksils12: fixing coverity issue 185331
2017-12-14 16:04:53 +01:00
Rainer Gerhards
39d0e4352a maintain ChangeLog 2017-12-14 15:59:42 +01:00
Rainer Gerhards
568271f26c
Merge pull request #2214 from rgerhards/libbson-bug
work-around libbson compiler warning
2017-12-14 15:54:32 +01:00
Jan Gerhards
4de1050b0e omzmq3: use new errmsg interface
see also https://github.com/rsyslog/rsyslog/issues/1684
2017-12-14 14:17:23 +01:00
Rainer Gerhards
d8528315ab pmrfc3164: fix invalid whitespace-skip
regression from yesterday's commit, deteced by Coverity Scan,
CID 186292
2017-12-14 12:54:17 +01:00
Rainer Gerhards
ffa7d48fa2 Merge branch 'issue_2098' of https://github.com/HugoSoszynski/rsyslog into libbson-bug 2017-12-14 12:38:44 +01:00
Allan Park
5b720b3c8e lmsig_ksils12: fixing coverity issue 185331 2017-12-14 11:30:14 +02:00
Rainer Gerhards
5ca051bc92 work-around libbson compiler warning
this is fixed in newer versions of libbson, but we do not
want to force using the newer ones just because of this issue.
2017-12-13 15:54:44 +01:00
Rainer Gerhards
86ad82c66d maintain ChangeLog 2017-12-13 13:01:30 +01:00
Rainer Gerhards
6a23fc32e3
Merge pull request #2205 from rgerhards/i-2048
cleanup: remove unused runtime instrumentation code
2017-12-13 12:57:25 +01:00
Rainer Gerhards
90ea3d5eb2 maintain ChangeLog 2017-12-13 10:27:23 +01:00
Rainer Gerhards
27f075ee69
Merge pull request #2206 from rgerhards/i-2030
pmrfc3164: try to detected headerless message
2017-12-13 10:22:26 +01:00