12686 Commits

Author SHA1 Message Date
Rainer Gerhards
223e5e9ced testbench: support dynamic pidfile naming
required for parallel test execution

This also fixes some previously not seen issues with HOSTNAME
file generation inside the test framework.
2018-08-15 08:28:11 +02:00
Rainer Gerhards
f926afb846
Merge pull request #2919 from rgerhards/tb-parallel2
testbench: make some test files dynamic
2018-08-13 15:06:37 +02:00
Rainer Gerhards
dbe61eb06b
testbench: make some test files dynamic
This is work torward the ability to run the testbench in parallel.
Some small issues in tests have also been detected, which were not
previously seen. They have been fixed. We did not do separate
commits for this as it would clutter the commit log with not
really relevant info.

Also move some cleanup to "make clean" target

To support parallel testbench runs, we need to have dynamic work files.
So deleting work files on each test does not work, especially as we can
no longer assume they are "left-overs" from a failed test - they may
actually (and quite likely) belong to tests that run in parallel.

So the proper solution is to do via "make clean".

closes https://github.com/rsyslog/rsyslog/pull/2916
2018-08-13 15:04:47 +02:00
Rainer Gerhards
89368ed04a
Merge pull request #2923 from friedl/test_refactor8
Test refactoring part 8
2018-08-13 14:32:00 +02:00
Florian Riedl
2d22742f32 Test refactoring part 8 2018-08-13 12:58:30 +02:00
Rainer Gerhards
4bbf117b56
maintain ChangeLog 2018-08-13 09:23:25 +02:00
Rainer Gerhards
de9c40d1ac
Merge pull request #2922 from rgerhards/i2921
omprog: add ability to pass rsyslog's environment to script
2018-08-13 09:22:41 +02:00
Rainer Gerhards
f13bbf22cc
omprog: add ability to pass rsyslog's environment to script
Up until 8.37.0, rsyslog provides an empty environment to the spawned
program. This seems to work in existing use case. However, there are
use cases where rsyslog's environment should be inherited, at least
this is needed for the testbench. There, we need to have access to
the output file name, which is now dynamically be generated to support
parallel test execution. We assume environment access would also be
useful for other use cases as well.

see also https://github.com/rsyslog/rsyslog/issues/2921
2018-08-13 08:15:21 +02:00
Rainer Gerhards
2a355c779d
maintain ChangeLog 2018-08-12 18:36:24 +02:00
Rainer Gerhards
c325991a97
Merge pull request #2917 from jsiwrk/bugfix/omprog_logs_severity
omprog: fix severity of some log messages in waitForChild
2018-08-12 18:34:07 +02:00
Rainer Gerhards
ef95919c3f
Merge pull request #2918 from sjvs/patch-1
Add LGTM.com code quality badges
2018-08-12 13:16:17 +02:00
Bas van Schaik
7a57ae08a8
Add LGTM.com code quality badges 2018-08-09 15:26:03 +01:00
Joan Sala
7622be4c4c omprog: fix severity of some log messages in waitForChild
Log some messages related to child process termination as info/warn
instead of error.
2018-08-09 10:28:07 +02:00
Rainer Gerhards
09e592bdab
Merge pull request #2911 from rgerhards/uxsockrcvr2
testbench: uxsockrcvr cleanup did try to kill "grep" process
2018-08-03 16:58:45 +02:00
Rainer Gerhards
2e3375c2c2
correct ChangeLog entry
see also https://github.com/rsyslog/rsyslog/pull/2749#issuecomment-410241495
2018-08-03 14:49:48 +02:00
Rainer Gerhards
fc6edc1fb4
testbench: uxsockrcvr cleanup did try to kill "grep" process
this was harmless, but generated irritating messages in test log
2018-08-03 14:42:04 +02:00
Rainer Gerhards
2cdc12bebc
Merge pull request #2903 from rgerhards/ci-known-issue
testbench: suppress known issue
2018-08-03 13:37:36 +02:00
Rainer Gerhards
6508400ff2
maintain ChangeLog 2018-08-03 13:37:05 +02:00
Rainer Gerhards
3f9c1a423a
Merge pull request #2749 from jvymazal/wildcard_symlink
Symlink support for imfile
2018-08-03 13:32:25 +02:00
Rainer Gerhards
55e3e58214
Merge pull request #2910 from PascalWithopf/codestyle-finalize
activate codestyle for all files ending with .c/.h
2018-08-03 12:37:24 +02:00
Rainer Gerhards
69381fad65
testbench: suppress known issue
see also https://github.com/rsyslog/rsyslog/issues/2902
2018-08-03 12:04:59 +02:00
Jiri Vymazal
3822da837e Symlink support for imfile
this introduces symlink detection and following as well
as monitoring changes on them. Also added test for the new
functionality and ensuring the original symlink behavior
stays as well.
2018-08-03 11:35:28 +02:00
PascalWithopf
866336d997 activate codestyle for all files ending with .c/.h
Last changes to the codestyle and activation of
the codestyle checker.
2018-08-03 09:32:07 +02:00
Rainer Gerhards
e6bbba4e5b
bump version number for new development cycle 2018-08-03 09:03:22 +02:00
Rainer Gerhards
e49271a370
prepare for 8.37.0 release v8.37.0 2018-08-03 08:46:32 +02:00
Rainer Gerhards
e0479e8468
Merge pull request #2901 from rgerhards/codestyle-fix
codestyle fix - rough way
2018-08-03 08:13:39 +02:00
Rainer Gerhards
e53fae6224
Merge pull request #2904 from rgerhards/uxsocksrvr-cleanup
testbench: cleanup hanging uxsocksrvr instances
2018-08-02 20:52:27 +02:00
Rainer Gerhards
616c45a733
testbench: cleanup hanging uxsocksrvr instances
We still see hanging instances, so we for now resort to kill them.
The uxsockrcvr tool itself should timeout after a while.
2018-08-02 17:22:17 +02:00
Rainer Gerhards
4f9fc5ad9f
Merge pull request #2900 from rgerhards/tb2
testbench: more modernization of testbench plumbing
2018-08-02 17:06:00 +02:00
Rainer Gerhards
4f8cfcbb54
codestyle fix - rough way
We did not totally fix all that we would like to see changed, but we
fixed it so that it permits us to finally run the style checker on all
files.

Needs some little manual fixup PR to follow.
2018-08-02 15:21:22 +02:00
Rainer Gerhards
d8b6dc52af
testbench: more modernization of testbench plumbing 2018-08-02 14:47:19 +02:00
Rainer Gerhards
a029820c58
Merge pull request #2898 from PascalWithopf/codestyle
correct codestyle in rsyslog part 2
2018-08-02 09:07:10 +02:00
PascalWithopf
c83e3ed216 correct codestyle in rsyslog part 2 2018-08-01 16:11:33 +02:00
Rainer Gerhards
8ea166d89d
testbench: fix some hardcoded names (#2895)
* testbench: fix some hardcoded names

This is prework to make parallel execution of tests possible.
2018-08-01 12:52:17 +02:00
Rainer Gerhards
801d78d289
Merge pull request #2897 from jvymazal/imjournal_leak
Fixed resource leak in persistJournalState()
2018-08-01 12:40:25 +02:00
Jiri Vymazal
0b3cb3401b Fixed resource leak in persistJournalState()
If fputs() failed we aborted without closing opened handle
2018-08-01 09:49:39 +02:00
Rainer Gerhards
2dfd9b5d2d
Merge pull request #2894 from rgerhards/sndrcv_tests
testbench: prototype of sndrcv test in modern style
2018-08-01 09:26:15 +02:00
Rainer Gerhards
653357fdaa
Merge pull request #2896 from friedl/test_refactor7
Test refactor part 7 - multi configs
2018-08-01 08:36:30 +02:00
Florian Riedl
ed89157982 Test refactor part 7 - multi configs 2018-07-31 15:52:50 +02:00
Rainer Gerhards
6bb5bc91f5
testbench: prototype of sndrcv test in modern style 2018-07-31 15:26:46 +02:00
Rainer Gerhards
6fdca3835c
maintain ChangeLog 2018-07-31 14:47:44 +02:00
Rainer Gerhards
cac7d3693f
Merge pull request #2543 from jvymazal/imjournal_rewrite
Fetching cursor on readJournal() and simplified pollJournal()
2018-07-31 14:44:08 +02:00
Rainer Gerhards
84efdcc122
Merge pull request #2889 from rgerhards/no-kafka-tests
Travis: temporarily disable kafka tests
2018-07-31 14:24:36 +02:00
Jiri Vymazal
59e58b5ec8 Fetching cursor on readJournal() and simplified pollJournal()
Fetching journal cursor in persistJournal could cause us to save
invalid cursor leading to duplicating messages further on, when new
WorkAroundJournalBug option is set we are saving it on each
readJournal() where we now that the state is good.

pollJournal() is now cleaner and faster, correctly handles INVALIDATE
status from journald and is able to continue polling after journal
flush. Also reduced POLL_TIMEOUT a bit as it caused rsyslog to exit
with error in corner cases for some ppc when left at full second.

re-factored imjournal CI tests with journal_print tool to have more
detailed error reporting
2018-07-31 12:08:25 +02:00
Rainer Gerhards
1f8f621a97
Merge pull request #2893 from PascalWithopf/codestyle
correct codestyle in rsyslog
2018-07-31 12:00:41 +02:00
Rainer Gerhards
f0ba3e2f21
maintain ChangeLog 2018-07-31 10:19:12 +02:00
Rainer Gerhards
aecb19bb5a
Merge pull request #2891 from rgerhards/imdiag-dynamic-port
testbench: make port for imdiag dynamic
2018-07-31 10:17:28 +02:00
PascalWithopf
19133327cc correct codestyle in rsyslog 2018-07-31 09:44:27 +02:00
Rainer Gerhards
6617e5c8a6
testbench: ensure test leaves no dangling listener instances
In case the test aborts. We utilize the timeout utility for now
to prevent this.
2018-07-31 08:33:08 +02:00
Rainer Gerhards
861751b24e
testbench: make port for imdiag dynamic 2018-07-30 19:34:25 +02:00