10304 Commits

Author SHA1 Message Date
Dan Molik
315fa5259c validate mmdblookup test
- streamline testing with ruleset and mmnormalize
2017-01-25 13:20:07 -05:00
Rainer Gerhards
ba2bc0755c maintain ChangeLog 2017-01-25 10:17:32 +01:00
Rainer Gerhards
d5c6ee3567 Merge pull request #1371 from alorbach/imfile-multilevelwildcard
Imfile multilevelwildcard
2017-01-25 10:15:06 +01:00
Rainer Gerhards
197b99c2e6 maintain ChangeLog 2017-01-25 10:10:37 +01:00
Rainer Gerhards
d8e56c14b7 Merge pull request #1378 from rgerhards/i-1376
fix issues with set/unset statements
2017-01-25 10:08:03 +01:00
Rainer Gerhards
756e871f82 testbench: add test to ensure no memleak in "set" statement 2017-01-25 08:48:59 +01:00
Rainer Gerhards
114605a0fc imtcp: fix very small (cosmetic) memory leak
For each listener, the name of an assigned ruleset is not freed. This
is cosmetic, because it is a very small static leak AND it needs to
be kept until end of run anyways (and at end of run the OS frees it).

However, the leak breaks memleak checks in the testbench.
2017-01-24 15:07:56 +01:00
Rainer Gerhards
03a6b2bf34 testbench: add test for invalid var name with set/unset
see also https://github.com/rsyslog/rsyslog/issues/1377
2017-01-24 14:44:15 +01:00
Rainer Gerhards
e2767839bc rainescript: set/unset statement do not check variable name validity
Only JSON-based variables can be use with set and unset. Unfortunately,
this restriction is not checked. If an invalid variable is given
(e.g. $invalid), this is not detected upon config processing on
startup. During execution phase, this can lead to a segfault, a
memory leak or other types of problems.

see also https://github.com/rsyslog/rsyslog/issues/1376
closes https://github.com/rsyslog/rsyslog/issues/1377
2017-01-24 13:24:29 +01:00
Rainer Gerhards
026cfbef3b maintain ChangeLog 2017-01-23 15:39:09 +01:00
Rainer Gerhards
e318309c61 Merge pull request #1357 from GrayTShirt/mmdb-stylecheck
mmdblookup module cleanup
2017-01-23 15:37:49 +01:00
Rainer Gerhards
c88c575f21 maintain ChangeLog 2017-01-23 15:36:01 +01:00
Rainer Gerhards
6f8e3e49a4 Merge pull request #1375 from rgerhards/i-1351
bugfix: rsyslog loops on freebsd when trying to write /dev/console
2017-01-23 15:34:00 +01:00
faca9c8ced imfile: Fixed bug in dynamic dir watch found using testsuite.
testsuite: Also added msleep between directory and file creation
in imfile wildcard tests. Sometimes a directory watch was not created
before the testsuite created a logfile.
2017-01-19 13:41:00 +01:00
Dan Molik
55c080e83e disable mmdblookup tests, until debugging 2017-01-18 13:37:28 -05:00
Damien Fleuriot
ee136aa582 bugfix: rsyslog loops on freebsd when trying to write /dev/console
Rsyslog 8.23.0 loops on FreeBSD when trying to access a (now revoked) /dev/console file descriptor, as per Alexandre's original bug report [1].

The original patch fixes the problem when tryTTYRecover() sees errno 6 ENXIO.

Running FreeBSD 10-stable here and getting errno 5 EIO, same as Xavier gets in his 2016 bug report [2].

New patch [3] includes errno 5 to tryTTYRecover() in runtime/stream.c and fixes the problem for me, on multiple machines.

[1] https://github.com/rsyslog/rsyslog/issues/371
[2] https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=211033
[3] https://bz-attachments.freebsd.org/attachment.cgi?id=178452

closes https://github.com/rsyslog/rsyslog/issues/1351
2017-01-18 18:58:59 +01:00
658f1e062c testsuite: Fixed state filename in some elasticsearch tests.
These tests only worked before, because the statefile was not written
due an issue fixed in commit:
2f7b371017
2017-01-18 12:55:41 +01:00
478f2762ae imfile: Fixed codestyle issues and restored code from previous commits. 2017-01-18 10:46:26 +01:00
ca3850c601 imfile: Moved getBaseDir to inotify functions 2017-01-17 15:24:04 +01:00
Rainer Gerhards
74387aa2da Merge pull request #1370 from rgerhards/i-1343
debug build: fix invalid assertion
2017-01-17 15:13:03 +01:00
9e5ff29489 imfile: Added testcase for multilevel wildcard directories
Also fixed a bug in new wildcard dir handling
found using this test.
2017-01-17 14:38:32 +01:00
2f7b371017 imfile: Fixed an issue generating wrong statefiles when $workdirectory is unset
When $WorkDirectory was not configured in rsyslog configuration, invalid
path/filenames were generated for statefiles causing failure on
deleting statefiles and more.
2017-01-17 14:38:32 +01:00
8025057e39 imfile: Fixed multiple bugs in new wildcard directory handling
Fixed removal for directory watch and helper functions
Fixed invalid setupdirwatch indexes.
Changed logfile extensions for new tests
2017-01-17 14:38:32 +01:00
3bf605255a testsuite: Added 3 new tests for imfile checking wildcard support.
Testing wildcards matching in filename and directory name including
dynamically adding and removing directories and files.
2017-01-17 14:38:32 +01:00
9a6b321b5b imfile: Added support for multilevel wildcards (inotify only)
imfile supports now wildcards on multiple levels.
Directories can be dynamically added and removed.
Each directory has its own inotify watch.

Initial coding is done, no propper tests have to be added.
2017-01-17 14:38:32 +01:00
Rainer Gerhards
00509ec1e9 debug build: fix invalid assertion
closes https://github.com/rsyslog/rsyslog/issues/1343
2017-01-17 12:30:54 +01:00
Rainer Gerhards
43db4f8233 Merge pull request #1362 from PascalWithopf/linelength
codestyle: line length adjusted
2017-01-17 10:26:23 +01:00
Pascal Withopf
b63a6b9010 codestyle: line length adjusted 2017-01-17 08:54:37 +01:00
Rainer Gerhards
61a285d7e8 maintain ChangeLog 2017-01-16 11:51:22 +01:00
Rainer Gerhards
0359812765 Merge pull request #1366 from rgerhards/i-1365
add option "parser.PermitSlashInProgramname"
2017-01-16 11:50:44 +01:00
Rainer Gerhards
4997e54b88 maintain ChangeLog 2017-01-16 11:50:15 +01:00
Rainer Gerhards
9358db4017 Merge pull request #1369 from hese10/master
For ratelimit checking, added check for time going backwards.
2017-01-16 11:49:05 +01:00
Heikki Kemppainen
a6c8f9ad68 For ratelimit checking, added check for time going backwards. If time goes backwards, then ratelimit begin and done values must be set to zero 2017-01-16 09:26:29 +02:00
Rainer Gerhards
6c8566b1f7 Merge pull request #1368 from dpocock/pymongo-3
plugins/ommongodb/clean-mongo-syslog: support for MongoClient API
2017-01-15 11:31:57 +01:00
Rainer Gerhards
3d58c63e99 testbench: add tests for "parser.PermitSlashInProgramname" 2017-01-15 11:18:15 +01:00
Daniel Pocock
5c066da81e plugins/ommongodb/clean-mongo-syslog: support for MongoClient API 2017-01-15 08:38:47 +01:00
Dan Molik
a82752fa19 Test file needs to be executable 2017-01-13 15:25:44 -05:00
Dan Molik
fde42481b6 enusre we build libmaxmind from source for Ubuntu percise (12.04) and trusty (14.04) 2017-01-13 14:42:08 -05:00
Dan Molik
591eb7dbc2 Compile ip-lookup module during testing
- fix clang compilation by switching to BEGINdoAction_nostring
2017-01-13 13:41:52 -05:00
Rainer Gerhards
98f2c08155 maintain ChangeLog 2017-01-13 18:55:55 +01:00
Rainer Gerhards
cfcbe0a66d Merge pull request #1364 from rgerhards/i-1279
bugfix: bFlushOnTxEnd == 0 not honored when writing w/o async writer
2017-01-13 18:54:54 +01:00
Rainer Gerhards
471f503063 add option "parser.PermitSlashInProgramname"
The new option permits to have slashes inside the programname
property. This is counter the BSD syslog defintitions, but
sometimes useful (e.g. the journal records path names, which
obviously contain slashes).

closes https://github.com/rsyslog/rsyslog/issues/1365
see also https://github.com/rsyslog/rsyslog/issues/1361
2017-01-13 15:08:57 +01:00
Dan Molik
6a4b10d861 Cleanup mmdb lookup readme 2017-01-13 08:59:36 -05:00
Rainer Gerhards
7619ad2c20 bugfix: bFlushOnTxEnd == 0 not honored when writing w/o async writer
If bFlushOnTXEnd is set, we need to flush on transaction end - in
any case. It is not relevant if this is using background writes
(which then become pretty slow) or not. And, similarly, no flush
happens when it is not set.

closes https://github.com/rsyslog/rsyslog/issues/1297
2017-01-13 13:51:37 +01:00
Dan Molik
f6451bb20b mmdblookup - fix building
- minor coding style issues.
- fix compiler warnings
  * string const
  * function prototype
- fix compiler error, msg_t -> smsg_t
- fix libfastjson function deprecation.
- drop libjson environments file, as it is extraneous.
2017-01-12 16:57:24 -05:00
Dan Molik
f24662817c Stylecheck the mmdblookup module 2017-01-12 14:43:06 -05:00
Rainer Gerhards
1c8da91c9f Merge branch 'master' of https://github.com/rsyslog/rsyslog 2017-01-11 13:41:25 +01:00
Rainer Gerhards
2eec29c855 Merge pull request #1356 from PascalWithopf/imfilecodestyle
codestyle: check imfile.c
2017-01-11 13:41:02 +01:00
Pascal Withopf
1198652e54 codestyle: check imfile.c 2017-01-11 11:45:22 +01:00
Rainer Gerhards
c5f2e64bcb Merge pull request #1347 from dsahern/man-page
Update the rsyslog.conf man page for device option
2017-01-11 09:02:17 +01:00