12716 Commits

Author SHA1 Message Date
95ed2c573b testbench: Switched to newer kafka/zookeeper versions.
Fixed test configurations (socket timeouts with newer kafka).
Reactivated some kafka tests that work now.

omkafka: Fixed "closeTimeout" setting in action shutdown
2018-08-21 15:00:44 +02:00
Rainer Gerhards
670d6661ec
maintain ChangeLog 2018-08-20 19:16:34 +02:00
Rainer Gerhards
0a1b740e94
Merge pull request #2774 from nhosoi/bz1309698
[WIP] "fromhost" property's case is lowered when using UDP
2018-08-20 19:11:21 +02:00
Rainer Gerhards
0530de6611
Merge pull request #2946 from jsiwrk/bugfix/omprog_writepipe_offset
omprog: fix invalid memory access on partial writes to pipe
2018-08-20 16:53:35 +02:00
Rainer Gerhards
130b30c29b
Merge pull request #2944 from rgerhards/tb-makerules
testbench: force sequence of execution for some tests
2018-08-20 16:52:16 +02:00
Rainer Gerhards
1eb5f12f4a
testbench: force sequence of execution for some tests (plus some nits)
also some smaller changes
- some cleanup in testbench tooling
- testbench: better diagnostics in journal test
  prototype change, may be propagated to other tests if it really turns
  out to be useful - but only the next time will show if it is...
- make imjournal-basic-vg.sh SKIP in successful run (but when fully done)
  This is an aid to address failures in imjournal-basic.sh, which
  experiences an odd bug that we suspect to be rooted inside the journal.
  see also https://github.com/rsyslog/rsyslog/issues/2931#issuecomment-414269118
2018-08-20 14:05:28 +02:00
Joan Sala
196870db59 omprog: fix invalid memory access on partial writes to pipe 2018-08-19 17:52:35 +02:00
Rainer Gerhards
efff926b05
maintain ChangeLog 2018-08-19 13:10:24 +02:00
Rainer Gerhards
9664f2b059
Merge pull request #2943 from rgerhards/omprog-environ
omprog: remove "hideEnvironment" parameter as this is a bugfix
2018-08-19 12:21:43 +02:00
Rainer Gerhards
c87c5bcd98
Merge pull request #2942 from rgerhards/tb6
testbench: some minor improvements
2018-08-19 12:18:58 +02:00
Rainer Gerhards
7f1f11c5a2
omprog: remove "hideEnvironment" parameter as this is a bugfix
discussion confirmed that not passing environment to called program
should be considered a bug and consequently no parameter to control
this behaviour is needed. I just added that parameter to be able
to carry on with testbench work, and this commit removes it. The
param was never part of any official relase.

closes https://github.com/rsyslog/rsyslog/issues/2921
2018-08-19 08:41:12 +02:00
Rainer Gerhards
5a7d6009c7
testbench: some minor improvements
- DEAD_PORT now uses unassigned IANA port unlike to be used on the system
  (dynamic port querying is racy and we had at least once an issue, so we
  can remove ambiguity here easily)
- replace some diag.sh commands by bash functions
2018-08-19 08:35:19 +02:00
Rainer Gerhards
ce74f03db4
Merge pull request #2941 from rgerhards/tb5
testbench: replace hardcoded port 13514
2018-08-19 08:26:28 +02:00
Rainer Gerhards
1ed6859dfd
testbench: replace hardcoded ports and improve cleanup handling
Support tools (like tcpflood) are also upgraded to support the
necessary dynamic port.s

This is part of the effort to make parallel testing possible.

We move parts of the cleanup to the buildbot cleanup, as we cannot
clean out instances on each test when we run parallel tests.
2018-08-18 20:28:31 +02:00
Rainer Gerhards
c90ab7c304
Merge pull request #2935 from rgerhards/tb-noconf
testbench: remove no longer needed .conf files
2018-08-17 14:31:29 +02:00
Rainer Gerhards
a5b9fbc026
testbench: remove no longer needed .conf files
they have been replaced by the new config system
2018-08-17 12:05:43 +02:00
Rainer Gerhards
55daa206f7
testbench: make "started" file name dymamically (#2936)
* testbench: make "started" file name dymamic

required for parallel test execution
2018-08-16 20:14:18 +02:00
Noriko Hosoi
9ac54f0d7d Introducing an option preservecase to imudp and imtcp module for
managing the case of FROMHOST value.

Usage:
module(load="imudp" [preservecase="on"|"off"])
module(load="imtdp" [preservecase="on"|"off"])

If preservecase="on", FROMHOST value is handled in the case sensitive manner.
If preservecase="off", FROMHOST value is handled in the case insensitive manner.

To maintain the current behaviour, the default value of preservecase is
"on" for imtcp and "off" for imudp.

Incremented tcpsrvCURR_IF_VERSION by 1.

References:
https://github.com/rsyslog/rsyslog/pull/2774
https://bugzilla.redhat.com/show_bug.cgi?id=1309698
2018-08-16 06:22:13 -07:00
Pascal Withopf
b20dbd52bd codestyle: give error message when codestyle is incorrect (#2933)
The codestyle script will now put out an error message
when the codestyle is incorrect, explaining what went wrong
and providing a link to the documentation.
2018-08-15 18:53:39 +02:00
friedl
493ed7af8f Test Refactor part 9 - DONOTMERGE (#2928)
* Testbench refactoring part 9
2018-08-15 17:20:11 +02:00
Rainer Gerhards
22bdacd70f
Merge pull request #2926 from rgerhards/tb-parallel3
testbench: support dynamic pidfile naming
2018-08-15 11:57:50 +02:00
Rainer Gerhards
d816dd0da5
Merge pull request #2932 from rgerhards/cid190890
core/regex: emit error message when hashtable entry could not be inse…
2018-08-15 10:20:11 +02:00
Rainer Gerhards
0f187c76b4
core/regex: emit error message when hashtable entry could not be inserted
detected by Coverity Scan, CID 190890
2018-08-15 08:43:56 +02:00
Rainer Gerhards
0f8002f1bc
Merge pull request #2914 from jvymazal/symlink_rotation
Enhanced symlink rotation support
2018-08-15 08:36:26 +02:00
Rainer Gerhards
223e5e9ced testbench: support dynamic pidfile naming
required for parallel test execution

This also fixes some previously not seen issues with HOSTNAME
file generation inside the test framework.
2018-08-15 08:28:11 +02:00
Rainer Gerhards
97e94e95c3
Merge pull request #2927 from rgerhards/cid191197
imfile: try to "fix" Coverity false positive
2018-08-14 13:12:30 +02:00
Rainer Gerhards
8760889137
imfile: try to "fix" Coverity false positive
Coverity seems not to understand realpath() API, but we nevertheless
want to have a clean Coverity report. So we hope this silences it.

CID 1911977
2018-08-13 15:47:51 +02:00
Rainer Gerhards
edaf0f220e
maintain ChangeLog 2018-08-13 15:41:00 +02:00
Rainer Gerhards
6ac5c95dbb
Merge pull request #2906 from richm/omelasticsearch-retry-add-metadata
write all header metadata to omes for retries
2018-08-13 15:33:03 +02:00
Rainer Gerhards
f926afb846
Merge pull request #2919 from rgerhards/tb-parallel2
testbench: make some test files dynamic
2018-08-13 15:06:37 +02:00
Rainer Gerhards
dbe61eb06b
testbench: make some test files dynamic
This is work torward the ability to run the testbench in parallel.
Some small issues in tests have also been detected, which were not
previously seen. They have been fixed. We did not do separate
commits for this as it would clutter the commit log with not
really relevant info.

Also move some cleanup to "make clean" target

To support parallel testbench runs, we need to have dynamic work files.
So deleting work files on each test does not work, especially as we can
no longer assume they are "left-overs" from a failed test - they may
actually (and quite likely) belong to tests that run in parallel.

So the proper solution is to do via "make clean".

closes https://github.com/rsyslog/rsyslog/pull/2916
2018-08-13 15:04:47 +02:00
Rainer Gerhards
89368ed04a
Merge pull request #2923 from friedl/test_refactor8
Test refactoring part 8
2018-08-13 14:32:00 +02:00
Florian Riedl
2d22742f32 Test refactoring part 8 2018-08-13 12:58:30 +02:00
Rainer Gerhards
4bbf117b56
maintain ChangeLog 2018-08-13 09:23:25 +02:00
Rainer Gerhards
de9c40d1ac
Merge pull request #2922 from rgerhards/i2921
omprog: add ability to pass rsyslog's environment to script
2018-08-13 09:22:41 +02:00
Rainer Gerhards
f13bbf22cc
omprog: add ability to pass rsyslog's environment to script
Up until 8.37.0, rsyslog provides an empty environment to the spawned
program. This seems to work in existing use case. However, there are
use cases where rsyslog's environment should be inherited, at least
this is needed for the testbench. There, we need to have access to
the output file name, which is now dynamically be generated to support
parallel test execution. We assume environment access would also be
useful for other use cases as well.

see also https://github.com/rsyslog/rsyslog/issues/2921
2018-08-13 08:15:21 +02:00
Rainer Gerhards
2a355c779d
maintain ChangeLog 2018-08-12 18:36:24 +02:00
Rainer Gerhards
c325991a97
Merge pull request #2917 from jsiwrk/bugfix/omprog_logs_severity
omprog: fix severity of some log messages in waitForChild
2018-08-12 18:34:07 +02:00
Rainer Gerhards
ef95919c3f
Merge pull request #2918 from sjvs/patch-1
Add LGTM.com code quality badges
2018-08-12 13:16:17 +02:00
Bas van Schaik
7a57ae08a8
Add LGTM.com code quality badges 2018-08-09 15:26:03 +01:00
Joan Sala
7622be4c4c omprog: fix severity of some log messages in waitForChild
Log some messages related to child process termination as info/warn
instead of error.
2018-08-09 10:28:07 +02:00
Jiri Vymazal
9454e13da0 Enhanced symlink rotation support
Now watching target directory as well to properly catch rotation
of files monitored via symlink.
2018-08-09 10:17:47 +02:00
Rich Megginson
eb11580336 write all header metadata to omes for retries
Write all of the original request metadata fields to $.omes for
the retry, if present. This may include all of the following:
_index, _type, _id, _parent, pipeline
This is in addition to the fields from the response. If the same
field name exists in the request metadata and the response, the
field from the request will be used, in order to facilitate
retrying the exact same request.
Have to set a tag with `MsgSetTAG` to avoid a UBSAN error.
2018-08-06 14:20:10 -06:00
Rainer Gerhards
09e592bdab
Merge pull request #2911 from rgerhards/uxsockrcvr2
testbench: uxsockrcvr cleanup did try to kill "grep" process
2018-08-03 16:58:45 +02:00
Rainer Gerhards
2e3375c2c2
correct ChangeLog entry
see also https://github.com/rsyslog/rsyslog/pull/2749#issuecomment-410241495
2018-08-03 14:49:48 +02:00
Rainer Gerhards
fc6edc1fb4
testbench: uxsockrcvr cleanup did try to kill "grep" process
this was harmless, but generated irritating messages in test log
2018-08-03 14:42:04 +02:00
Rainer Gerhards
2cdc12bebc
Merge pull request #2903 from rgerhards/ci-known-issue
testbench: suppress known issue
2018-08-03 13:37:36 +02:00
Rainer Gerhards
6508400ff2
maintain ChangeLog 2018-08-03 13:37:05 +02:00
Rainer Gerhards
3f9c1a423a
Merge pull request #2749 from jvymazal/wildcard_symlink
Symlink support for imfile
2018-08-03 13:32:25 +02:00
Rainer Gerhards
55e3e58214
Merge pull request #2910 from PascalWithopf/codestyle-finalize
activate codestyle for all files ending with .c/.h
2018-08-03 12:37:24 +02:00