11290 Commits

Author SHA1 Message Date
Rainer Gerhards
ab9abd5f5b imkafka bugfix: cosmetic memory leak upon rsyslog termination
OS will cleanup, not a real issue, but polluts memory debuggers.
2017-11-17 15:29:02 +01:00
Rainer Gerhards
b331549a17 omkafka bugfix: cosmetic memory leak upon rsyslog termination
OS will cleanup, not a real issue, but pollutes memory debuggers.
2017-11-17 15:29:02 +01:00
Rainer Gerhards
51d3263622 omkafka: refactor code, unify failedmsg object constuction 2017-11-17 15:28:56 +01:00
Rainer Gerhards
0c4c7deda7 omkafka bugfix: memory leak
Whenever a message could (temporarily) not be delivered to kafka,
a non-trivial amount of memory was leaked. This could sum up to
quite a big memory leak.

fixes https://github.com/rsyslog/rsyslog/issues/1991
2017-11-17 15:10:07 +01:00
Rainer Gerhards
19cebbf092 omkafka: refactor failed delivery handling and error reporting 2017-11-17 15:10:07 +01:00
Rainer Gerhards
010e9e8156 omkafka: cleanup
make code follow our coding guidelines a bit better
2017-11-17 12:03:23 +01:00
Rainer Gerhards
b4b0309995 testbench: cleanup existing kafka tests 2017-11-17 12:03:23 +01:00
Rainer Gerhards
0dfe06dfc8 maintain ChangeLog 2017-11-17 12:02:59 +01:00
Rainer Gerhards
f96a4c8ab3
Merge pull request #2041 from flisky/master
omkafka: make maxoutqsize resettable
2017-11-17 12:00:39 +01:00
Yin Jifeng
75a3b887ea omkafka: make maxoutqsize resettable 2017-11-17 17:56:06 +08:00
Rainer Gerhards
8506104ad2 maintain ChangeLog 2017-11-17 10:02:42 +01:00
Rainer Gerhards
81b58202fa
Merge pull request #2045 from rgerhards/cid-185722
omkafka: refactor deletion of failed message file
2017-11-17 09:59:26 +01:00
Rainer Gerhards
40d69f5f28
Merge pull request #2039 from rgerhards/i-1949
omelasticsearch bugfix: some config params not consistenly applied
2017-11-17 09:52:45 +01:00
Rainer Gerhards
2fa497f1bd omkafka: refactor deletion of failed message file
Code used a suboptimal command sequence. Refactored this and also
cleaned up things a bit.

Detected by Coverity scan, CID 185722
2017-11-16 15:50:05 +01:00
Rainer Gerhards
73127e3b66 omelasticsearch bugfix: some config params not consistenly applied
Authentication credentials were not applied during health check,
permission to use unsigned CERTS was not applied to regular data
post.

Also done a bit refactoring to unify curl setup as much as possible.

fixes https://github.com/rsyslog/rsyslog/issues/1949
2017-11-16 15:49:34 +01:00
Rainer Gerhards
b7d684c701
Merge pull request #2044 from rgerhards/i-2037
Travis CI: add support for cron jobs & Coverity scan
2017-11-16 15:48:34 +01:00
Rainer Gerhards
0d124d164a Travis: let build requirements not interfere with line length check 2017-11-16 13:47:47 +01:00
Rainer Gerhards
6c05f41269 Travis CI: add support for cron jobs and Coverity scan
We execute different code pathes under cron jobs. It doesn't make sense
to redo what we already did before a merge. Right now, cron builds a
Coverity scan submission and uploads it. This should be set to run
once a day.

closes https://github.com/rsyslog/rsyslog/issues/2037
2017-11-16 11:30:01 +01:00
Rainer Gerhards
b02016f301
Merge pull request #2042 from jgerhards/errmsg-templatec
template: use new errmsg interface
2017-11-15 16:57:15 +01:00
Rainer Gerhards
230cdd9359
Merge pull request #2043 from jgerhards/errmsg-omczmq
omczmq: : use new errmsg interface
2017-11-15 16:56:52 +01:00
Jan Gerhards
bf1476d81a omczmq: : use new errmsg interface 2017-11-15 13:08:41 +01:00
Jan Gerhards
ceddd7e75d template: use new errmsg interface 2017-11-15 13:03:57 +01:00
Rainer Gerhards
e838d66d6d
Merge pull request #1994 from PascalWithopf/line_length_correction
codestyle: shorten lines to max 130 chars
2017-11-15 10:48:20 +01:00
PascalWithopf
e485c5c5bc codestyle: shorten lines to max 130 chars 2017-11-15 09:04:42 +01:00
Rainer Gerhards
c0c23e258e
Merge pull request #2022 from rgerhards/cid-185407
lookup: improve code in regard to err detection at compile time
2017-11-14 17:06:03 +01:00
Rainer Gerhards
928a2e46d9 maintain ChangeLog 2017-11-14 16:39:19 +01:00
Rainer Gerhards
cad09a1a3e
Merge pull request #2033 from rgerhards/i-2005
travis: run clang static analyzer over ALL files
2017-11-14 16:37:38 +01:00
Rainer Gerhards
743daa3762
Merge pull request #2035 from rgerhards/cid-185402
Coverity scan false positive "fixes"
2017-11-14 16:36:38 +01:00
Rainer Gerhards
a79b1062f6
Merge pull request #2031 from rgerhards/cid-185362
omrelp: incorrect error handling
2017-11-14 16:35:23 +01:00
Rainer Gerhards
4b0f69d0ec testbench: check rsyslogd abort if tcpflood fails
this is useful if rsyslogd only abort in such tests - otherwise we
do not get a core analysis
2017-11-14 14:27:11 +01:00
Rainer Gerhards
31bd05dfce remove unnecessary code 2017-11-14 14:27:11 +01:00
Rainer Gerhards
1f109c53ca lookup: improve code in regard to err detection at compile time
Trying to understand CID 185407, which looks like a false positive. On
the way to this, add attributation which could increase correctness of
compiler code unerstanding and trigger different set of error messages.
2017-11-14 14:27:05 +01:00
Rainer Gerhards
fb760e9ec2 "fix" Coverity scan false positive in libgcry, CID 185408 2017-11-14 13:15:35 +01:00
Rainer Gerhards
4c5ab15010 "fix" Coverity scan false positive CID 185433 2017-11-14 13:11:31 +01:00
Rainer Gerhards
2fc94fce33 travis: run clang static analyzer over ALL files
For historic reasons, it only processed part of the files, what no longer
is necessary (buildbot already covers everything).

closes https://github.com/rsyslog/rsyslog/issues/2005
2017-11-14 12:20:32 +01:00
Rainer Gerhards
90a06a8e5d omrelp: code cleanup 2017-11-14 11:56:02 +01:00
Rainer Gerhards
f83c828625 omrelp: incorrect error handling
if librelp with TLS but without Authentication was included, librelp
did not emit the correct error message due to invalid error code
check. It also did not err-out but instead suspended itself.

Detected by Coverity scan, CID 185362
2017-11-14 11:54:23 +01:00
Rainer Gerhards
7ef2e34059 maintain ChangeLog 2017-11-14 11:31:36 +01:00
Rainer Gerhards
87231dcaba
Merge pull request #1914 from WaeCo/v8-stable
omelasticsearch: add dynamic pipeline support
2017-11-14 11:23:37 +01:00
Rainer Gerhards
3d010fe53a maintain ChangeLog 2017-11-14 10:48:42 +01:00
Rainer Gerhards
fb621b7bc7
Merge pull request #1393 from artbristol/tls-client-sni
Support SNI when connecting as a client
2017-11-14 10:40:40 +01:00
Niels Becker
785382d17a Merge branch 'master' of https://github.com/rsyslog/rsyslog into HEAD 2017-11-14 10:35:07 +01:00
Rainer Gerhards
20d1426554
Merge pull request #2029 from rgerhards/cid-185340
rscryutil bugfix: decryption error potentially undetected
2017-11-14 10:29:22 +01:00
Rainer Gerhards
e46eb9e44a
Merge pull request #2028 from jgerhards/errsg-actionc
action: use new errmsg interface
2017-11-14 10:29:09 +01:00
Rainer Gerhards
21f56adfac core: remove unnecessary check
Deteced by Coverity scan, CID 185324
2017-11-13 19:18:09 +01:00
Rainer Gerhards
af7b02b350 rscryutil bugfix: decryption error potentially undetected
Detectec by Coverity scan, CID 185340
2017-11-13 18:51:15 +01:00
Jan Gerhards
f6352925ae action: use new errmsg interface 2017-11-13 18:48:33 +01:00
Rainer Gerhards
0f95dce5be
Merge pull request #2027 from rgerhards/cid-185416
imdiag: blocking pstats did not always work correctly
2017-11-13 15:39:20 +01:00
Rainer Gerhards
66fd9146a1 imdiag: blocking pstats did not always work correctly
data type was not correctly re-cast after atomic operation

Also added a couple of code attributes to aid compiler finding bugs.

Detected by Coverity scan, CID 185416
2017-11-13 12:14:16 +01:00
Rainer Gerhards
ca41b8ee11 maintain ChangeLog 2017-11-13 11:22:57 +01:00